Bug 223604

Summary: Distinction between m_webPageID and m_identifier in WebPageProxy is extremely unclear
Product: WebKit Reporter: Sam Weinig <sam>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: NEW ---    
Severity: Normal CC: cdumez, kkinnunen, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   

Description Sam Weinig 2021-03-22 15:02:11 PDT
WebPageProxy has two identifiers, m_webPageID and m_identifier in WebPageProxy is extremely unclear. There are no comments indicating how these are different, or how they should be used, and the names make them seem identical.

My understanding is that m_webPageID can mutate on process swap, so it should probably have a more clear name, like identifierOfCurrentWebPage, or something like that, and there should be documentation explaining this.
Comment 1 Radar WebKit Bug Importer 2021-03-29 15:03:13 PDT
<rdar://problem/75975008>