Bug 223593

Summary: Resync web-platform-tests/css/css-grid tests from upstream
Product: WebKit Reporter: zsun
Component: CSSAssignee: zsun
Status: RESOLVED FIXED    
Severity: Normal CC: clopez, ews-watchlist, jfernandez, obrufau, rego, svillar, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description zsun 2021-03-22 12:45:30 PDT 
Resync web-platform-tests/css/css-grid tests from upstream
Comment 1 zsun 2021-03-22 13:30:14 PDT 
Created attachment 423929 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2021-03-29 12:46:13 PDT 
<rdar://problem/75968162>
Comment 3 zsun 2021-06-22 07:53:07 PDT 
Created attachment 431964 [details]
Patch
Comment 4 Sergio Villar Senin 2021-06-22 09:00:11 PDT 
Comment on attachment 431964 [details]
Patch

OK for me assuming EWS are happy.
Comment 5 zsun 2021-06-23 01:43:17 PDT 
Created attachment 432025 [details]
Patch
Comment 6 zsun 2021-06-23 02:36:40 PDT 
Created attachment 432027 [details]
Patch
Comment 7 zsun 2021-06-23 03:10:47 PDT 
Created attachment 432029 [details]
Patch
Comment 8 zsun 2021-06-23 05:25:44 PDT 
Created attachment 432032 [details]
Patch
Comment 9 Manuel Rego Casasnovas 2021-06-24 01:25:47 PDT 
Comment on attachment 432032 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432032&action=review

r=me

> LayoutTests/ChangeLog:8
> +        * TestExpectations:

Nit: I think you miss the iOS TestExpecations file linked here.

> LayoutTests/TestExpectations:1221
> +imported/w3c/web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-align-self-002.html [ ImageOnlyFailure ]

It'd be really nice to associate these with some bugs. Some are related to alignment and baseline, so a bunch of them could point to a single generic bug.
Comment 10 zsun 2021-06-24 02:11:22 PDT 
Created attachment 432141 [details]
Patch
Comment 11 zsun 2021-06-24 02:14:03 PDT 
(In reply to Manuel Rego Casasnovas from comment #9)
> Comment on attachment 432032 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=432032&action=review
> 
> r=me
> 
> > LayoutTests/ChangeLog:8
> > +        * TestExpectations:
> 
> Nit: I think you miss the iOS TestExpecations file linked here.
> 
Addressed.

> > LayoutTests/TestExpectations:1221
> > +imported/w3c/web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-align-self-002.html [ ImageOnlyFailure ]
> 
> It'd be really nice to associate these with some bugs. Some are related to
> alignment and baseline, so a bunch of them could point to a single generic
> bug.

I will investigate them, and report bugs accordingly and update the TestExcpectations to refer to them. For the time being, as we discussed, leave as they are.
Comment 12 EWS 2021-06-25 01:31:24 PDT 
Committed r279269 (239148@main): <https://commits.webkit.org/239148@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 432141 [details].