Resync web-platform-tests/css/css-grid tests from upstream
Created attachment 423929 [details] Patch
<rdar://problem/75968162>
Created attachment 431964 [details] Patch
Comment on attachment 431964 [details] Patch OK for me assuming EWS are happy.
Created attachment 432025 [details] Patch
Created attachment 432027 [details] Patch
Created attachment 432029 [details] Patch
Created attachment 432032 [details] Patch
Comment on attachment 432032 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=432032&action=review r=me > LayoutTests/ChangeLog:8 > + * TestExpectations: Nit: I think you miss the iOS TestExpecations file linked here. > LayoutTests/TestExpectations:1221 > +imported/w3c/web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-align-self-002.html [ ImageOnlyFailure ] It'd be really nice to associate these with some bugs. Some are related to alignment and baseline, so a bunch of them could point to a single generic bug.
Created attachment 432141 [details] Patch
(In reply to Manuel Rego Casasnovas from comment #9) > Comment on attachment 432032 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=432032&action=review > > r=me > > > LayoutTests/ChangeLog:8 > > + * TestExpectations: > > Nit: I think you miss the iOS TestExpecations file linked here. > Addressed. > > LayoutTests/TestExpectations:1221 > > +imported/w3c/web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-align-self-002.html [ ImageOnlyFailure ] > > It'd be really nice to associate these with some bugs. Some are related to > alignment and baseline, so a bunch of them could point to a single generic > bug. I will investigate them, and report bugs accordingly and update the TestExcpectations to refer to them. For the time being, as we discussed, leave as they are.
Committed r279269 (239148@main): <https://commits.webkit.org/239148@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432141 [details].