Bug 223589

Summary:

[webkitcorepy] Print output of setup.py when install fails

Product:

WebKit

Reporter:

Jonathan Bedard <jbedard>

Component:

Tools / Tests

Assignee:

Jonathan Bedard <jbedard>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, dewei_zhu, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Jonathan Bedard 2021-03-22 11:31:21 PDT

When the autoinstaller fails to install a Python library, we should print the output of setup.py.

Comment 1 Radar WebKit Bug Importer 2021-03-22 11:31:32 PDT

<rdar://problem/75700606>

Comment 2 Jonathan Bedard 2021-03-22 11:34:52 PDT

Created attachment 423914 [details]
Patch

Comment 3 Aakash Jain 2021-03-22 12:05:50 PDT

Comment on attachment 423914 [details]
Patch

is this tested?

Comment 4 Jonathan Bedard 2021-03-22 12:35:17 PDT

(In reply to Aakash Jain from comment #3)
> Comment on attachment 423914 [details]
> Patch
> 
> is this tested?

Not via unit tests, although we probably could make unit tests for the autoinstaller now (would not have practical when this code was originally landed)

Comment 5 EWS 2021-03-23 09:23:23 PDT

Committed r274875: <https://commits.webkit.org/r274875>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423914 [details].