Bug 223589 - [webkitcorepy] Print output of setup.py when install fails
Summary: [webkitcorepy] Print output of setup.py when install fails
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-22 11:31 PDT by Jonathan Bedard
Modified: 2021-03-23 09:23 PDT (History)
3 users (show)

See Also:

Attachments
Patch (6.45 KB, patch)
2021-03-22 11:34 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2021-03-22 11:31:21 PDT 
When the autoinstaller fails to install a Python library, we should print the output of setup.py.
Comment 1 Radar WebKit Bug Importer 2021-03-22 11:31:32 PDT 
<rdar://problem/75700606>
Comment 2 Jonathan Bedard 2021-03-22 11:34:52 PDT 
Created attachment 423914 [details]
Patch
Comment 3 Aakash Jain 2021-03-22 12:05:50 PDT 
Comment on attachment 423914 [details]
Patch

is this tested?
Comment 4 Jonathan Bedard 2021-03-22 12:35:17 PDT 
(In reply to Aakash Jain from comment #3)
> Comment on attachment 423914 [details]
> Patch
> 
> is this tested?

Not via unit tests, although we probably could make unit tests for the autoinstaller now (would not have practical when this code was originally landed)
Comment 5 EWS 2021-03-23 09:23:23 PDT 
Committed r274875: <https://commits.webkit.org/r274875>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423914 [details].