Bug 223588

Summary: [JSC] JSCustomGetterFunction/JSCustomSetterFunction should use Identifier for their field
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch mark.lam: review+

Yusuke Suzuki
Reported 2021-03-22 11:22:50 PDT
[JSC] JSCustomGetterFunction/JSCustomSetterFunction should use Identifier for their field
Attachments
Patch (6.09 KB, patch)
2021-03-22 11:24 PDT, Yusuke Suzuki 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (6.32 KB, patch)
2021-03-22 11:27 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (9.62 KB, patch)
2021-03-22 12:01 PDT, Yusuke Suzuki 		mark.lam: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2021-03-22 11:24:37 PDT
Created attachment 423912 [details] Patch
Yusuke Suzuki
Comment 2 2021-03-22 11:27:24 PDT
Created attachment 423913 [details] Patch
Mark Lam
Comment 3 2021-03-22 11:55:01 PDT
Comment on attachment 423913 [details] Patch r=me
Yusuke Suzuki
Comment 4 2021-03-22 12:01:14 PDT
Created attachment 423915 [details] Patch
Saam Barati
Comment 5 2021-03-22 12:14:37 PDT
Comment on attachment 423915 [details] Patch LGTM too
Yusuke Suzuki
Comment 6 2021-03-22 16:30:35 PDT
Committed r274817 (235615@main): <https://commits.webkit.org/235615@main>
Radar WebKit Bug Importer
Comment 7 2021-03-22 16:31:18 PDT
<rdar://problem/75714374>
Note You need to log in before you can comment on or make changes to this bug.