Bug 223556

Summary: AX: textRectsFromMarkers always fails
Product: WebKit Reporter: chris fleizach <cfleizach>
Component: AccessibilityAssignee: chris fleizach <cfleizach>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, commit-queue, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 223746    
Bug Blocks:    
Attachments:
Description Flags
patch
none
patch
none
patch
none
patch none

Description chris fleizach 2021-03-20 10:41:34 PDT 
The textRectsFromMarkers:text: method is always failing to return a valid answer because these methods to extend the search range

auto startPosition = visiblePositionForPositionWithOffset(makeContainerOffsetPosition(originalRange.start), -textLength);
auto endPosition = visiblePositionForPositionWithOffset(makeContainerOffsetPosition(originalRange.start), 2 * textLength);

create a range that can't be iterated
Comment 1 chris fleizach 2021-03-20 10:41:49 PDT 
<rdar://74256003>
Comment 2 chris fleizach 2021-03-20 10:47:19 PDT 
Created attachment 423817 [details]
patch
Comment 3 chris fleizach 2021-03-22 09:17:20 PDT 
Created attachment 423895 [details]
patch
Comment 4 EWS 2021-03-22 17:22:06 PDT 
Committed r274826: <https://commits.webkit.org/r274826>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423895 [details].
Comment 5 WebKit Commit Bot 2021-03-25 06:40:31 PDT 
Re-opened since this is blocked by bug 223746
Comment 6 chris fleizach 2021-03-25 09:16:09 PDT 
Created attachment 424250 [details]
patch
Comment 7 chris fleizach 2021-03-31 00:07:10 PDT 
Created attachment 424737 [details]
patch
Comment 8 EWS 2021-04-02 10:41:54 PDT 
Committed r275425: <https://commits.webkit.org/r275425>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 424737 [details].