| Summary: | [JSC] Intl.Locale should not assume is8Bit | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||
| Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ews-watchlist, keith_miller, mark.lam, msaboff, ross.kirsling, saam, tzagallo, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Yusuke Suzuki
2021-03-20 03:35:09 PDT
Created attachment 423808 [details]
Patch
Comment on attachment 423808 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423808&action=review r=me. This comes as a shock to me, since we have in fact verified all the characters of these strings by this point. :( > Source/JavaScriptCore/runtime/IntlLocale.cpp:180 > + Vector<char, 32> rawValue; > + rawValue.resize(value.length() + 1); Is this different from using the constructor param? Comment on attachment 423808 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423808&action=review >> Source/JavaScriptCore/runtime/IntlLocale.cpp:180 >> + rawValue.resize(value.length() + 1); > > Is this different from using the constructor param? No. Changed :) Committed r274784 (235588@main): <https://commits.webkit.org/235588@main> |