Bug 223553

Summary: [JSC] Intl.Locale should not assume is8Bit
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, ross.kirsling, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ross.kirsling: review+

Yusuke Suzuki
Reported 2021-03-20 03:35:09 PDT
[JSC] Intl.Locale should not assume is8Bit
Attachments
Patch (4.52 KB, patch)
2021-03-20 03:36 PDT, Yusuke Suzuki 		ross.kirsling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2021-03-20 03:36:53 PDT
Created attachment 423808 [details] Patch
Ross Kirsling
Comment 2 2021-03-20 17:01:06 PDT
Comment on attachment 423808 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423808&action=review r=me. This comes as a shock to me, since we have in fact verified all the characters of these strings by this point. :( > Source/JavaScriptCore/runtime/IntlLocale.cpp:180 > + Vector<char, 32> rawValue; > + rawValue.resize(value.length() + 1); Is this different from using the constructor param?
Yusuke Suzuki
Comment 3 2021-03-22 13:05:53 PDT
Comment on attachment 423808 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423808&action=review >> Source/JavaScriptCore/runtime/IntlLocale.cpp:180 >> + rawValue.resize(value.length() + 1); > > Is this different from using the constructor param? No. Changed :)
Yusuke Suzuki
Comment 4 2021-03-22 13:09:24 PDT
Committed r274784 (235588@main): <https://commits.webkit.org/235588@main>
Radar WebKit Bug Importer
Comment 5 2021-03-22 13:10:24 PDT
<rdar://problem/75705456>
Note You need to log in before you can comment on or make changes to this bug.