Bug 223547

Summary: Provide a way to specify platform vs security key when requesting an assertion in the SPI
Product: WebKit Reporter: Jiewen Tan <jiewen_tan>
Component: WebKit Misc.Assignee: Jiewen Tan <jiewen_tan>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, bfulgham, cdumez, esprehn+autocc, ews-watchlist, gyuyoung.kim, jiewen_tan, kondapallykalyan, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
bfulgham: review+, bfulgham: commit-queue-
Patch for landing none

Description Jiewen Tan 2021-03-19 17:56:17 PDT 
Provide a way to specify platform vs security key when requesting an assertion in the SPI.
Comment 1 Jiewen Tan 2021-03-19 17:56:34 PDT 
rdar://74034746
Comment 2 Jiewen Tan 2021-03-19 18:46:10 PDT 
Created attachment 423799 [details]
Patch
Comment 3 Jiewen Tan 2021-03-22 17:01:01 PDT 
Created attachment 423962 [details]
Patch
Comment 4 Jiewen Tan 2021-03-23 01:02:41 PDT 
Created attachment 423994 [details]
Patch
Comment 5 Brent Fulgham 2021-03-23 10:38:10 PDT 
Comment on attachment 423994 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423994&action=review

r=me

> Source/WebCore/ChangeLog:5
> +        rdar://74034746

nit: <rdar://74034746>

> Source/WebCore/ChangeLog:15
> +        * Modules/webauthn/AuthenticatorAttachment.idl: Copied from Source/WebKit/UIProcess/API/Cocoa/_WKPublicKeyCredentialRequestOptions.mm.

I would say these two were "Moved from ...."

> Source/WebKit/ChangeLog:5
> +        rdar://74034746

Ditto

> Source/WebKit/ChangeLog:12
> +        * UIProcess/API/Cocoa/_WKAuthenticatorAttachment.h: Copied from Source/WebKit/UIProcess/API/Cocoa/_WKPublicKeyCredentialRequestOptions.mm.

Ditto "Moved from ..."
Comment 6 Jiewen Tan 2021-03-23 12:08:30 PDT 
Comment on attachment 423994 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423994&action=review

Thanks Brent for r+ this patch.

>> Source/WebCore/ChangeLog:5
>> +        rdar://74034746
> 
> nit: <rdar://74034746>

Fixed.

>> Source/WebCore/ChangeLog:15
>> +        * Modules/webauthn/AuthenticatorAttachment.idl: Copied from Source/WebKit/UIProcess/API/Cocoa/_WKPublicKeyCredentialRequestOptions.mm.
> 
> I would say these two were "Moved from ...."

It was auto-generated. Fixed.

>> Source/WebKit/ChangeLog:5
>> +        rdar://74034746
> 
> Ditto

Fixed.

>> Source/WebKit/ChangeLog:12
>> +        * UIProcess/API/Cocoa/_WKAuthenticatorAttachment.h: Copied from Source/WebKit/UIProcess/API/Cocoa/_WKPublicKeyCredentialRequestOptions.mm.
> 
> Ditto "Moved from ..."

Fixed.
Comment 7 Jiewen Tan 2021-03-23 12:11:33 PDT 
Created attachment 424047 [details]
Patch for landing
Comment 8 EWS 2021-03-23 13:00:56 PDT 
Committed r274894: <https://commits.webkit.org/r274894>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 424047 [details].