| Summary: | [LayoutTests] Convert http/tests/resourceLoadStatistics convert PHP to Python | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Gambrell <cgambrell> | ||||||||||||||||
| Component: | Tools / Tests | Assignee: | Chris Gambrell <cgambrell> | ||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||
| Severity: | Normal | CC: | achristensen, ap, ews-watchlist, hi, jbedard, ryanhaddad, webkit-bug-importer | ||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=220749 | ||||||||||||||||||
| Attachments: |
|
||||||||||||||||||
|
Description
Chris Gambrell
2021-03-19 15:26:07 PDT
Created attachment 423784 [details]
Patch
Created attachment 423825 [details]
Patch
Created attachment 423879 [details]
Patch
Comment on attachment 423879 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423879&action=review > LayoutTests/http/tests/resourceLoadStatistics/do-not-switch-session-on-navigation-to-prevalent-without-interaction.py:6 > + 'Cache-Control: no-store\r\n' Doesn't python support """multi-line string literals"""? > LayoutTests/http/tests/resourceLoadStatistics/switch-session-on-navigation-to-prevalent-with-interaction.py:10 > + '<head>\n' ditto Created attachment 423933 [details]
Patch
(In reply to Alex Christensen from comment #5) > Comment on attachment 423879 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=423879&action=review > > > LayoutTests/http/tests/resourceLoadStatistics/do-not-switch-session-on-navigation-to-prevalent-without-interaction.py:6 > > + 'Cache-Control: no-store\r\n' > > Doesn't python support """multi-line string literals"""? > > > LayoutTests/http/tests/resourceLoadStatistics/switch-session-on-navigation-to-prevalent-with-interaction.py:10 > > + '<head>\n' > > ditto Fixed in comment 6 Created attachment 424134 [details]
Patch
Comment on attachment 424134 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=424134&action=review > LayoutTests/http/tests/resourceLoadStatistics/resources/set-cookie-on-redirect.py:47 > + ) Should add an "else" that writes \r\n to stdout so that if something breaks our assumptions here we will still have a valid response > LayoutTests/http/tests/resourceLoadStatistics/resources/set-cookie.py:16 > + 'Set-Cookie: {}={}; expires={} GMT; Max-Age=2592000; path=/\r\n' Have enough in here that I think naming your string arguments would be helpful. Created attachment 424167 [details]
Patch
(In reply to Jonathan Bedard from comment #9) > Comment on attachment 424134 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=424134&action=review > > > LayoutTests/http/tests/resourceLoadStatistics/resources/set-cookie-on-redirect.py:47 > > + ) > > Should add an "else" that writes \r\n to stdout so that if something breaks > our assumptions here we will still have a valid response > > > LayoutTests/http/tests/resourceLoadStatistics/resources/set-cookie.py:16 > > + 'Set-Cookie: {}={}; expires={} GMT; Max-Age=2592000; path=/\r\n' > > Have enough in here that I think naming your string arguments would be > helpful. Fixed in comment 10 Committed r274975: <https://commits.webkit.org/r274975> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424167 [details]. Reopening for last PHP file to convert to Python Created attachment 426139 [details]
Patch
Committed r276109 (236609@main): <https://commits.webkit.org/236609@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426139 [details]. |