| Summary: | [GPUP] Add a "wallTime" field to struct RemoteMediaPlayerState | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Peng Liu <peng.liu6> | ||||||||||||
| Component: | New Bugs | Assignee: | Peng Liu <peng.liu6> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | calvaris, cdumez, changseok, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jer.noble, jonlee, philipj, sergio, webkit-bug-importer | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=221693 | ||||||||||||||
| Bug Depends on: | |||||||||||||||
| Bug Blocks: | 221693 | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Peng Liu
2021-03-19 10:23:47 PDT
Created attachment 423755 [details]
Patch
Created attachment 423756 [details]
Patch
Created attachment 423774 [details]
Fix test failures and update TestExpectations
Comment on attachment 423774 [details] Fix test failures and update TestExpectations View in context: https://bugs.webkit.org/attachment.cgi?id=423774&action=review > Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp:814 > + m_cachedState.timestamp = WallTime::now(); Nit: I think 'wallTime' might be more clear than 'timestamp' Comment on attachment 423774 [details] Fix test failures and update TestExpectations View in context: https://bugs.webkit.org/attachment.cgi?id=423774&action=review >> Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp:814 >> + m_cachedState.timestamp = WallTime::now(); > > Nit: I think 'wallTime' might be more clear than 'timestamp' Good idea! Will fix it after getting results from bots. Created attachment 423805 [details]
Patch for landing
Revise the patch based on Eric's comment and fix a layout test failure in the previous version.
Created attachment 423806 [details]
Patch for landing - v2
Committed r274816: <https://commits.webkit.org/r274816> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423806 [details]. |