Bug 223520

Summary: [WebXR] Enumerate XR devices via ChromeClient in WebXRSystem
Product: WebKit Reporter: Ada Chan <adachan>
Component: WebXRAssignee: Ada Chan <adachan>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, dino, ews-watchlist, gyuyoung.kim, ifernandez, ryuan.choi, sam, sergio, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Ada Chan
Reported 2021-03-19 09:57:42 PDT
[WebXR] Enumerate XR devices via ChromeClient in WebXRSystem
Attachments
Patch (5.90 KB, patch)
2021-03-19 09:59 PDT, Ada Chan 		no flags
DetailsFormatted DiffDiff
Patch (6.87 KB, patch)
2021-03-19 11:12 PDT, Ada Chan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ada Chan
Comment 1 2021-03-19 09:59:52 PDT
Created attachment 423741 [details] Patch
Sam Weinig
Comment 2 2021-03-19 10:34:38 PDT
Comment on attachment 423741 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423741&action=review > Source/WebCore/ChangeLog:14 > + * Modules/webxr/WebXRSystem.cpp: > + (WebCore::WebXRSystem::ensureImmersiveXRDeviceIsSelected): > + * WebCore.xcodeproj/project.pbxproj: > + * page/ChromeClient.h: > + (WebCore::ChromeClient::enumerateImmersiveXRDevices): > + * platform/xr/PlatformXR.h: > + Ada, can you fill this out, including the rationale for this? Specifically, that we want to avoid singletons in the WebProcess and want to be able to proxy the devices from the UIProcess.
Ada Chan
Comment 3 2021-03-19 11:12:30 PDT
Created attachment 423749 [details] Patch
EWS
Comment 4 2021-03-22 17:05:34 PDT
Committed r274821: <https://commits.webkit.org/r274821> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423749 [details].
Radar WebKit Bug Importer
Comment 5 2021-03-22 17:07:10 PDT
<rdar://problem/75715802>
Note You need to log in before you can comment on or make changes to this bug.