| Summary: | [WebXR] Enumerate XR devices via ChromeClient in WebXRSystem | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ada Chan <adachan> | ||||||
| Component: | WebXR | Assignee: | Ada Chan <adachan> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | annulen, dino, ews-watchlist, gyuyoung.kim, ifernandez, ryuan.choi, sam, sergio, thorton, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Ada Chan
2021-03-19 09:57:42 PDT
Created attachment 423741 [details]
Patch
Comment on attachment 423741 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423741&action=review > Source/WebCore/ChangeLog:14 > + * Modules/webxr/WebXRSystem.cpp: > + (WebCore::WebXRSystem::ensureImmersiveXRDeviceIsSelected): > + * WebCore.xcodeproj/project.pbxproj: > + * page/ChromeClient.h: > + (WebCore::ChromeClient::enumerateImmersiveXRDevices): > + * platform/xr/PlatformXR.h: > + Ada, can you fill this out, including the rationale for this? Specifically, that we want to avoid singletons in the WebProcess and want to be able to proxy the devices from the UIProcess. Created attachment 423749 [details]
Patch
Committed r274821: <https://commits.webkit.org/r274821> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423749 [details]. |