Summary: | [macOS] Context menu should account for image overlay content | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> | ||||||
Component: | Platform | Assignee: | Wenson Hsieh <wenson_hsieh> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bdakin, cdumez, changseok, esprehn+autocc, ews-watchlist, gyuyoung.kim, hi, megan_gardner, mifenton, thorton, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Wenson Hsieh
2021-03-19 09:21:35 PDT
Created attachment 423767 [details]
Patch
Comment on attachment 423767 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423767&action=review r=me > Source/WebCore/html/HTMLElement.cpp:1240 > + if (auto host = node.shadowHost(); is<HTMLElement>(host) && downcast<HTMLElement>(*host).hasImageOverlay()) > + return makeRefPtr(downcast<HTMLElement>(*host)); NIT: Can we avoid the double dereference-`downcast`? Comment on attachment 423767 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423767&action=review >> Source/WebCore/html/HTMLElement.cpp:1240 >> + return makeRefPtr(downcast<HTMLElement>(*host)); > > NIT: Can we avoid the double dereference-`downcast`? Yes, fixed! Created attachment 423783 [details]
Patch
Committed r274772: <https://commits.webkit.org/r274772> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423783 [details]. |