Bug 223483

Summary: LiteralParser shouldn't make error messages of length ~2^31
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, rmorisset, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
rmorisset: review+
patch
none
patch
ews-feeder: commit-queue-
patch for landing none

Saam Barati
Reported 2021-03-18 14:47:21 PDT
...
Attachments
patch (3.73 KB, patch)
2021-03-18 15:24 PDT, Saam Barati 		rmorisset: review+
DetailsFormatted DiffDiff
patch (3.76 KB, patch)
2021-03-18 18:10 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch (3.76 KB, patch)
2021-03-18 18:12 PDT, Saam Barati 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
patch for landing (4.44 KB, patch)
2021-03-22 12:16 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2021-03-18 15:18:45 PDT
<rdar://75572255>
Saam Barati
Comment 2 2021-03-18 15:24:59 PDT
Created attachment 423663 [details] patch
Robin Morisset
Comment 3 2021-03-18 15:27:28 PDT
Comment on attachment 423663 [details] patch r=me
Saam Barati
Comment 4 2021-03-18 18:06:49 PDT
The test failure doesn't reproduce for me locally ‼️
Saam Barati
Comment 5 2021-03-18 18:10:45 PDT
Created attachment 423676 [details] patch try different form of test just to see
Saam Barati
Comment 6 2021-03-18 18:12:20 PDT
Created attachment 423677 [details] patch this time without the syntax error
Saam Barati
Comment 7 2021-03-22 12:15:17 PDT
(In reply to Saam Barati from comment #6) > Created attachment 423677 [details] > patch > > this time without the syntax error This is a different test, I just assumed it was the one I wrote 🤦‍♂️
Saam Barati
Comment 8 2021-03-22 12:16:15 PDT
Created attachment 423917 [details] patch for landing
EWS
Comment 9 2021-03-22 16:01:54 PDT
Committed r274813: <https://commits.webkit.org/r274813> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423917 [details].
Note You need to log in before you can comment on or make changes to this bug.