Bug 223478

Summary: Address failing depth and stencil subcases in gl-object-get-calls
Product: WebKit Reporter: Kyle Piddington <kpiddington>
Component: WebGLAssignee: Kyle Piddington <kpiddington>
Status: RESOLVED CONFIGURATION CHANGED    
Severity: Normal CC: cdumez, changseok, dino, esprehn+autocc, ews-watchlist, graouts, gyuyoung.kim, kbr, kkinnunen, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=238691
Bug Depends on: 222964    
Bug Blocks: 222812    
Attachments:
Description Flags
Patch kbr: review+, ews-feeder: commit-queue-

Description Kyle Piddington 2021-03-18 13:51:12 PDT 
Address failing depth and stencil subcases in gl-object-get-calls
Comment 1 Kyle Piddington 2021-03-18 13:56:43 PDT 
Created attachment 423647 [details]
Patch
Comment 2 Kimmo Kinnunen 2021-03-19 06:58:42 PDT 
Great!

I haven't checked what the spec says about these yet.

I'd like to defer to review this until I've landed the correct tests.

Kenneth might be able to review these on top of his head, though.
Comment 3 Kenneth Russell 2021-03-19 11:37:07 PDT 
Comment on attachment 423647 [details]
Patch

Good catches; these look correct. r+
Comment 4 Radar WebKit Bug Importer 2021-03-25 13:52:18 PDT 
<rdar://problem/75851597>
Comment 5 Kimmo Kinnunen 2022-08-11 02:35:26 PDT 
I think the bugs were fixed in bug 229947 and bug 242408 so the patch is not needed anymore.