| Summary: | Don't spend time painting transparent cell backgrounds | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
| Component: | Layout and Rendering | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bfulgham, changseok, darin, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, zalan | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Simon Fraser (smfr)
2021-03-18 11:29:49 PDT
Created attachment 423622 [details]
Patch
Comment on attachment 423622 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423622&action=review > Source/WebCore/rendering/RenderTableCell.cpp:1287 > + if (!bgLayer.hasImage() && (!color.isValid() || !color.isVisible())) Typically we don’t also have to check isValid if we are checking isVisible, since the invalid color is also transparent block, and so guaranteed to be invisible. Comment on attachment 423622 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423622&action=review >> Source/WebCore/rendering/RenderTableCell.cpp:1287 >> + if (!bgLayer.hasImage() && (!color.isValid() || !color.isVisible())) > > Typically we don’t also have to check isValid if we are checking isVisible, since the invalid color is also transparent block, and so guaranteed to be invisible. transparent black |