Bug 223459

Summary: Don't spend time painting transparent cell backgrounds
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Layout and RenderingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, darin, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch darin: review+

Simon Fraser (smfr)
Reported 2021-03-18 11:29:49 PDT
Don't spend time painting transparent cell backgrounds
Attachments
Patch (3.95 KB, patch)
2021-03-18 11:31 PDT, Simon Fraser (smfr) 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2021-03-18 11:31:03 PDT
Created attachment 423622 [details] Patch
Darin Adler
Comment 2 2021-03-18 15:26:33 PDT
Comment on attachment 423622 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423622&action=review > Source/WebCore/rendering/RenderTableCell.cpp:1287 > + if (!bgLayer.hasImage() && (!color.isValid() || !color.isVisible())) Typically we don’t also have to check isValid if we are checking isVisible, since the invalid color is also transparent block, and so guaranteed to be invisible.
Darin Adler
Comment 3 2021-03-18 15:27:07 PDT
Comment on attachment 423622 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423622&action=review >> Source/WebCore/rendering/RenderTableCell.cpp:1287 >> + if (!bgLayer.hasImage() && (!color.isValid() || !color.isVisible())) > > Typically we don’t also have to check isValid if we are checking isVisible, since the invalid color is also transparent block, and so guaranteed to be invisible. transparent black
Simon Fraser (smfr)
Comment 4 2021-03-18 16:22:37 PDT
https://trac.webkit.org/changeset/274682/webkit
Radar WebKit Bug Importer
Comment 5 2021-03-18 16:23:33 PDT
<rdar://problem/75596249>
Note You need to log in before you can comment on or make changes to this bug.