Bug 223443

Summary: Implement RTCDataChannel transfer out of process
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, annulen, beidson, cdumez, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, hta, jer.noble, jsbell, kangil.han, philipj, ryuan.choi, sergio, tommyw, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch for landing none

Description youenn fablet 2021-03-18 06:53:38 PDT 
Implement RTCDataChannel transfer out of process
Comment 1 youenn fablet 2021-03-18 07:05:37 PDT 
Created attachment 423595 [details]
Patch
Comment 2 youenn fablet 2021-03-18 07:41:05 PDT 
Created attachment 423600 [details]
Patch
Comment 3 youenn fablet 2021-03-18 11:26:11 PDT 
Created attachment 423621 [details]
Patch
Comment 4 Eric Carlson 2021-03-19 10:29:49 PDT 
Comment on attachment 423621 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423621&action=review

> Source/WebKit/WebProcess/Network/webrtc/RTCDataChannelRemoteManager.cpp:73
> +    ASSERT(Process::identifier() == localIdentifier.processIdentifier);
> +    if (Process::identifier() != localIdentifier.processIdentifier)
> +        return false;
> +
> +    ASSERT(Process::identifier() == localIdentifier.processIdentifier);
> +    if (Process::identifier() != localIdentifier.processIdentifier)
> +        return false;

This is included twice

> Source/WebKit/WebProcess/Network/webrtc/RTCDataChannelRemoteManager.messages.in:34
> +    ChangeReadyState(struct WebCore::RTCDataChannelIdentifier handler, enum:uint8_t WebCore::RTCDataChannelState state);
> +    ReceiveData(struct WebCore::RTCDataChannelIdentifier handler, bool isRaw, IPC::DataReference data);
> +    DetectError(struct WebCore::RTCDataChannelIdentifier handler);
> +    BufferedAmountIsDecreasing(struct WebCore::RTCDataChannelIdentifier handler, size_t amount);

Are these tabs?
Comment 5 youenn fablet 2021-03-22 01:57:54 PDT 
Created attachment 423864 [details]
Patch for landing
Comment 6 EWS 2021-03-22 11:29:41 PDT 
Committed r274758: <https://commits.webkit.org/r274758>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423864 [details].
Comment 7 Radar WebKit Bug Importer 2021-03-22 11:30:24 PDT 
<rdar://problem/75700538>
Comment 8 youenn fablet 2021-03-22 11:40:39 PDT 
(In reply to Eric Carlson from comment #4)
> Comment on attachment 423621 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=423621&action=review
> 
> > Source/WebKit/WebProcess/Network/webrtc/RTCDataChannelRemoteManager.cpp:73
> > +    ASSERT(Process::identifier() == localIdentifier.processIdentifier);
> > +    if (Process::identifier() != localIdentifier.processIdentifier)
> > +        return false;
> > +
> > +    ASSERT(Process::identifier() == localIdentifier.processIdentifier);
> > +    if (Process::identifier() != localIdentifier.processIdentifier)
> > +        return false;
> 
> This is included twice

Fixed

> > Source/WebKit/WebProcess/Network/webrtc/RTCDataChannelRemoteManager.messages.in:34
> > +    ChangeReadyState(struct WebCore::RTCDataChannelIdentifier handler, enum:uint8_t WebCore::RTCDataChannelState state);
> > +    ReceiveData(struct WebCore::RTCDataChannelIdentifier handler, bool isRaw, IPC::DataReference data);
> > +    DetectError(struct WebCore::RTCDataChannelIdentifier handler);
> > +    BufferedAmountIsDecreasing(struct WebCore::RTCDataChannelIdentifier handler, size_t amount);
> 
> Are these tabs?

Not sure, but I removed them, thanks!