Bug 223443

Summary:

Implement RTCDataChannel transfer out of process

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

WebRTC

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

alecflett, annulen, beidson, cdumez, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, hta, jer.noble, jsbell, kangil.han, philipj, ryuan.choi, sergio, tommyw, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	ews-feeder: commit-queue-
Patch	none
Patch	none
Patch for landing	none

youenn fablet

Reported 2021-03-18 06:53:38 PDT

Implement RTCDataChannel transfer out of process

Attachments
Patch (143.73 KB, patch) 2021-03-18 07:05 PDT, youenn fablet	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (151.57 KB, patch) 2021-03-18 07:41 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (154.14 KB, patch) 2021-03-18 11:26 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch for landing (153.92 KB, patch) 2021-03-22 01:57 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

youenn fablet

Comment 1 2021-03-18 07:05:37 PDT

Created attachment 423595 [details] Patch

youenn fablet

Comment 2 2021-03-18 07:41:05 PDT

Created attachment 423600 [details] Patch

youenn fablet

Comment 3 2021-03-18 11:26:11 PDT

Created attachment 423621 [details] Patch

Eric Carlson

Comment 4 2021-03-19 10:29:49 PDT

Comment on attachment 423621 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423621&action=review > Source/WebKit/WebProcess/Network/webrtc/RTCDataChannelRemoteManager.cpp:73 > + ASSERT(Process::identifier() == localIdentifier.processIdentifier); > + if (Process::identifier() != localIdentifier.processIdentifier) > + return false; > + > + ASSERT(Process::identifier() == localIdentifier.processIdentifier); > + if (Process::identifier() != localIdentifier.processIdentifier) > + return false; This is included twice > Source/WebKit/WebProcess/Network/webrtc/RTCDataChannelRemoteManager.messages.in:34 > +Â Â ChangeReadyState(struct WebCore::RTCDataChannelIdentifier handler, enum:uint8_t WebCore::RTCDataChannelState state); > +Â Â ReceiveData(struct WebCore::RTCDataChannelIdentifier handler, bool isRaw, IPC::DataReference data); > +Â Â DetectError(struct WebCore::RTCDataChannelIdentifier handler); > +Â Â BufferedAmountIsDecreasing(struct WebCore::RTCDataChannelIdentifier handler, size_t amount); Are these tabs?

youenn fablet

Comment 5 2021-03-22 01:57:54 PDT

Created attachment 423864 [details] Patch for landing

EWS

Comment 6 2021-03-22 11:29:41 PDT

Committed r274758: <https://commits.webkit.org/r274758> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423864 [details].

Radar WebKit Bug Importer

Comment 7 2021-03-22 11:30:24 PDT

<rdar://problem/75700538>

youenn fablet

Comment 8 2021-03-22 11:40:39 PDT

(In reply to Eric Carlson from comment #4) > Comment on attachment 423621 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=423621&action=review > > > Source/WebKit/WebProcess/Network/webrtc/RTCDataChannelRemoteManager.cpp:73 > > + ASSERT(Process::identifier() == localIdentifier.processIdentifier); > > + if (Process::identifier() != localIdentifier.processIdentifier) > > + return false; > > + > > + ASSERT(Process::identifier() == localIdentifier.processIdentifier); > > + if (Process::identifier() != localIdentifier.processIdentifier) > > + return false; > > This is included twice Fixed > > Source/WebKit/WebProcess/Network/webrtc/RTCDataChannelRemoteManager.messages.in:34 > > +Â Â ChangeReadyState(struct WebCore::RTCDataChannelIdentifier handler, enum:uint8_t WebCore::RTCDataChannelState state); > > +Â Â ReceiveData(struct WebCore::RTCDataChannelIdentifier handler, bool isRaw, IPC::DataReference data); > > +Â Â DetectError(struct WebCore::RTCDataChannelIdentifier handler); > > +Â Â BufferedAmountIsDecreasing(struct WebCore::RTCDataChannelIdentifier handler, size_t amount); > > Are these tabs? Not sure, but I removed them, thanks!

Note You need to log in before you can comment on or make changes to this bug.