| Summary: | [CMake] Use an imported target for the LCMS2 library | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adrian Perez <aperez> | ||||||||
| Component: | Tools / Tests | Assignee: | Adrian Perez <aperez> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | annulen, cgarcia, clopez, don.olmstead, ews-watchlist, gyuyoung.kim, ryuan.choi, sergio, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Local Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=223340 | ||||||||||
| Bug Depends on: | 177185 | ||||||||||
| Bug Blocks: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Adrian Perez
2021-03-18 06:43:54 PDT
Created attachment 423594 [details]
Patch
This patch also includes a fix for bug #223340 — if we land this first, then we can skip that; if the other one lands first, I'll need to update and reupload this one. Either way is fine 👌️ I am going to update this now that the patch in bug #223340 has landed. Created attachment 423775 [details]
Patch v2
Rebased =)
/Volumes/Data/worker/Commit-Queue/build/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Comment on attachment 423775 [details] Patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=423775&action=review > Source/cmake/FindLCMS2.cmake:100 > +mark_as_advanced(LCMS2_INCLUDE_DIR LCMS2_LIBRARIES) This should be LCMS2_LIBRARY. You don't create LCMS2_LIBRARIES until further down. If you copy-pastaed it from somewhere else we should probably fix that. I thought I fixed the cases but could've missed one. (In reply to Don Olmstead from comment #6) > Comment on attachment 423775 [details] > Patch v2 > > View in context: > https://bugs.webkit.org/attachment.cgi?id=423775&action=review > > > Source/cmake/FindLCMS2.cmake:100 > > +mark_as_advanced(LCMS2_INCLUDE_DIR LCMS2_LIBRARIES) > > This should be LCMS2_LIBRARY. You don't create LCMS2_LIBRARIES until further > down. > > If you copy-pastaed it from somewhere else we should probably fix that. I > thought I fixed the cases but could've missed one. Good catch, thanks. This was only my fault; the rest of the CMake modules (at least the ones updated to follow the imported target style) look fine. I'll fix this before landing. Created attachment 424062 [details]
Patch for landing
Committed r274903: <https://commits.webkit.org/r274903> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424062 [details]. |