Summary: | Add WebGL 1.0.4 and 2.0.1 test files to the repository | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kimmo Kinnunen <kkinnunen> | ||||
Component: | WebGL | Assignee: | Kimmo Kinnunen <kkinnunen> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aakash_jain, dino, jdarpinian, kbr, kkinnunen, ryanhaddad, webkit-bot-watchers-bugzilla, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | Other | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 222964, 223586 | ||||||
Attachments: |
|
Description
Kimmo Kinnunen
2021-03-18 01:43:24 PDT
Created attachment 423574 [details]
Patch
Not 100% sure how this was intended to work, but I see that the files are being put into LayoutTests/webgl/resources/webgl_test_files. This generally seems fine though note you won't be able to version these, so the monikers "1.0.4" and "2.0.1" won't have the effect you intend. Maybe better to name those 1.0.x and 2.0.x to better show they're not strictly versioned. Will try to mark this r+, though having trouble doing so in the tool. +James. Committed r274711: <https://commits.webkit.org/r274711> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423574 [details]. (In reply to EWS from comment #4) > Committed r274711: <https://commits.webkit.org/r274711> webgl/conformance/extensions/khr-parallel-shader-compile.html seems to be consistently failing on iOS after this change. History: https://results.webkit.org/?suite=layout-tests&test=webgl%2Fconformance%2Fextensions%2Fkhr-parallel-shader-compile.html (In reply to Aakash Jain from comment #6) > (In reply to EWS from comment #4) > > Committed r274711: <https://commits.webkit.org/r274711> > webgl/conformance/extensions/khr-parallel-shader-compile.html seems to be > consistently failing on iOS after this change. Thanks! Strange, I thought I ran the iOS-simulator for that dir.. I can add that to the skip list if nobody else does it before, but only tomorrow.. |