Bug 223425 - Add WebGL 1.0.4 and 2.0.1 test files to the repository
Summary: Add WebGL 1.0.4 and 2.0.1 test files to the repository
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kimmo Kinnunen
URL:
Keywords: InRadar
Depends on:
Blocks: 222964 223586
  Show dependency treegraph
 
Reported: 2021-03-18 01:43 PDT by Kimmo Kinnunen
Modified: 2021-03-22 11:48 PDT (History)
8 users (show)

See Also:


Attachments
Patch (19.16 MB, patch)
2021-03-18 01:55 PDT, Kimmo Kinnunen
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2021-03-18 01:43:24 PDT
Add WebGL 1.0.4 and 2.0.1 test files to the repository

The import of the test suites is too big commit for the infrastructure to handle, so import partially.
Comment 1 Kimmo Kinnunen 2021-03-18 01:55:33 PDT
Created attachment 423574 [details]
Patch
Comment 2 Kenneth Russell 2021-03-18 13:17:13 PDT
Not 100% sure how this was intended to work, but I see that the files are being put into LayoutTests/webgl/resources/webgl_test_files. This generally seems fine though note you won't be able to version these, so the monikers "1.0.4" and "2.0.1" won't have the effect you intend. Maybe better to name those 1.0.x and 2.0.x to better show they're not strictly versioned.

Will try to mark this r+, though having trouble doing so in the tool.
Comment 3 Kenneth Russell 2021-03-18 13:17:25 PDT
+James.
Comment 4 EWS 2021-03-19 03:57:50 PDT
Committed r274711: <https://commits.webkit.org/r274711>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423574 [details].
Comment 5 Radar WebKit Bug Importer 2021-03-19 03:58:20 PDT
<rdar://problem/75614963>
Comment 6 Aakash Jain 2021-03-22 07:16:42 PDT
(In reply to EWS from comment #4)
> Committed r274711: <https://commits.webkit.org/r274711>
webgl/conformance/extensions/khr-parallel-shader-compile.html seems to be consistently failing on iOS after this change.

History: https://results.webkit.org/?suite=layout-tests&test=webgl%2Fconformance%2Fextensions%2Fkhr-parallel-shader-compile.html
Comment 8 Kimmo Kinnunen 2021-03-22 08:04:28 PDT
(In reply to Aakash Jain from comment #6)
> (In reply to EWS from comment #4)
> > Committed r274711: <https://commits.webkit.org/r274711>
> webgl/conformance/extensions/khr-parallel-shader-compile.html seems to be
> consistently failing on iOS after this change.


Thanks! Strange, I thought I ran the iOS-simulator for that dir..
I can add that to the skip list if nobody else does it before, but only tomorrow..