Bug 223422

Summary: CSP headers can block default <video> controls
Product: WebKit Reporter: Devin Rousso <hi>
Component: MediaAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, cdumez, cmarcelo, code, commit-queue, eric.carlson, esprehn+autocc, ews-watchlist, fnowak, glenn, graouts, hi, jer.noble, joepeck, kangil.han, philipj, ryanhaddad, sergio, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=225865
Bug Depends on: 223487    
Bug Blocks:    
Attachments:
Description Flags
Patch
graouts: review+, ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch none

Devin Rousso
Reported 2021-03-18 00:52:27 PDT
.
Attachments
Patch (2.76 KB, patch)
2021-03-18 01:00 PDT, Devin Rousso 		graouts: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (2.76 KB, patch)
2021-03-18 11:15 PDT, Devin Rousso 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (3.59 KB, patch)
2021-03-18 20:09 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2021-03-18 00:52:39 PDT
<rdar://problem/41192193>
Devin Rousso
Comment 2 2021-03-18 01:00:37 PDT
Created attachment 423569 [details] Patch
EWS
Comment 3 2021-03-18 03:08:02 PDT Comment hidden (obsolete)
Devin Rousso
Comment 4 2021-03-18 11:15:07 PDT
Created attachment 423620 [details] Patch I'm pretty sure the test failures were due to not having r274625 yet 🤔
EWS
Comment 5 2021-03-18 13:26:40 PDT
Committed r274669: <https://commits.webkit.org/r274669> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423620 [details].
Aakash Jain
Comment 6 2021-03-18 15:55:10 PDT
(In reply to Devin Rousso from comment #4) > I'm pretty sure the test failures were due to not having r274625 yet 🤔 https://ews-build.webkit.org/#/builders/56/builds/3789 used 235479@main (displayed in step 6) which is r274654. https://ews-build.webkit.org/#/builders/60/builds/131 used 235476@main which is r274651 r274654 and r274651 are after r274625. Please check. Also These tests are now crashing on post-commit bots too, e.g.: https://results.webkit.org/?suite=layout-tests&suite=layout-tests&test=http%2Ftests%2Finspector%2Fnetwork%2Fresource-initiatorNode.html&test=http%2Ftests%2Finspector%2Fdom%2FdidFireEvent.html
WebKit Commit Bot
Comment 7 2021-03-18 16:37:54 PDT
Re-opened since this is blocked by bug 223487
Devin Rousso
Comment 8 2021-03-18 20:09:47 PDT
Created attachment 423685 [details] Patch
EWS
Comment 9 2021-03-19 07:35:06 PDT
Committed r274717: <https://commits.webkit.org/r274717> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423685 [details].
Sam Sneddon [:gsnedders]
Comment 10 2022-02-14 19:06:11 PST
*** Bug 191782 has been marked as a duplicate of this bug. ***
Anne van Kesteren
Comment 11 2023-08-27 23:36:47 PDT
*** Bug 225865 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.