Bug 223422

Summary:

CSP headers can block default <video> controls

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Media

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, cdumez, cmarcelo, code, commit-queue, eric.carlson, esprehn+autocc, ews-watchlist, fnowak, glenn, graouts, hi, jer.noble, joepeck, kangil.han, philipj, ryanhaddad, sergio, webkit-bot-watchers-bugzilla, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=225865

Bug Depends on:

223487

Bug Blocks:

Attachments:

Description	Flags
Patch	graouts: review+, ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
Patch	none

Description Devin Rousso 2021-03-18 00:52:27 PDT

Comment 1 Devin Rousso 2021-03-18 00:52:39 PDT

<rdar://problem/41192193>

Comment 2 Devin Rousso 2021-03-18 01:00:37 PDT

Created attachment 423569 [details]
Patch

Comment 3 EWS 2021-03-18 03:08:02 PDT Comment hidden (obsolete)

Found 30 new test failures: compositing/video/video-object-fit.html, fast/canvas/webgl/texImage2D-video-flipY-true.html, http/tests/contentextensions/text-track-blocked.html, http/tests/inspector/network/resource-mime-type.html, http/tests/security/contentSecurityPolicy/report-only-connect-src-xmlhttprequest-redirect-to-blocked.php, media/modern-media-controls/css/cursor.html, media/modern-media-controls/css/pointer-events-none.html, media/modern-media-controls/css/transformed-media.html, media/modern-media-controls/css/webkit-cursor-visibility-auto-hide.html, media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag-is-prevented-over-button.html ...

Comment 4 Devin Rousso 2021-03-18 11:15:07 PDT

Created attachment 423620 [details]
Patch

I'm pretty sure the test failures were due to not having r274625 yet 🤔

Comment 5 EWS 2021-03-18 13:26:40 PDT

Committed r274669: <https://commits.webkit.org/r274669>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423620 [details].

Comment 6 Aakash Jain 2021-03-18 15:55:10 PDT

(In reply to Devin Rousso from comment #4)
> I'm pretty sure the test failures were due to not having r274625 yet 🤔

https://ews-build.webkit.org/#/builders/56/builds/3789 used 235479@main (displayed in step 6) which is r274654.
https://ews-build.webkit.org/#/builders/60/builds/131 used 235476@main which is r274651

r274654 and r274651 are after r274625. Please check.

Also These tests are now crashing on post-commit bots too, e.g.: https://results.webkit.org/?suite=layout-tests&suite=layout-tests&test=http%2Ftests%2Finspector%2Fnetwork%2Fresource-initiatorNode.html&test=http%2Ftests%2Finspector%2Fdom%2FdidFireEvent.html

Comment 7 WebKit Commit Bot 2021-03-18 16:37:54 PDT

Re-opened since this is blocked by bug 223487

Comment 8 Devin Rousso 2021-03-18 20:09:47 PDT

Created attachment 423685 [details]
Patch

Comment 9 EWS 2021-03-19 07:35:06 PDT

Committed r274717: <https://commits.webkit.org/r274717>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423685 [details].

Comment 10 Sam Sneddon [:gsnedders] 2022-02-14 19:06:11 PST

*** Bug 191782 has been marked as a duplicate of this bug. ***

Comment 11 Anne van Kesteren 2023-08-27 23:36:47 PDT

*** Bug 225865 has been marked as a duplicate of this bug. ***