Bug 22332

Summary: malformed interfaces in WebCore idls
Product: WebKit Reporter: Nathan Howell <nathanhowell>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Minor CC: ap, heycam, rwlbuis
Priority: P5    
Version: 528+ (Nightly build)   
Hardware: All   
OS: Windows Vista   
Attachments:
Description Flags
Proposed fix sam: review-

Nathan Howell
Reported 2008-11-18 01:42:49 PST
found these two inconsistent interfaces while developing a grammar to parse .idls. WebCore/svg/SVGSVGElement.idl: "setter raises" used on a method instead of "raises" WebCore/css/WebKitCSSTransformValue.idl: HasIndexGetter extended attribute is missing a comma
Attachments
Proposed fix (1.06 KB, patch)
2008-11-18 01:43 PST, Nathan Howell 		sam: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nathan Howell
Comment 1 2008-11-18 01:43:48 PST
Created attachment 25232 [details] Proposed fix
Sam Weinig
Comment 2 2008-11-18 09:50:16 PST
Comment on attachment 25232 [details] Proposed fix This needs a ChangeLog, but otherwise looks good. r- for the ChangeLog.
Alexey Proskuryakov
Comment 3 2008-11-19 05:04:08 PST
Does the WebKitCSSTransformValue problem cause a real bug? IIRC missing spaces are not ignored there, so the fix should correct actual behavior.
Cameron McCormack (:heycam)
Comment 4 2009-09-04 02:41:49 PDT
The "setter raises" part of this was fixed with http://trac.webkit.org/changeset/47890.
Rob Buis
Comment 5 2011-05-16 19:02:17 PDT
The HasIndexGetter part is also fixed nowadays, so I think we can close this. Cheers, Rob.
Note You need to log in before you can comment on or make changes to this bug.