Bug 223298

Summary: Only send image across XPC to GPU process if it changes.
Product: WebKit Reporter: Jean-Yves Avenard [:jya] <jean-yves.avenard>
Component: MediaAssignee: Jean-Yves Avenard [:jya] <jean-yves.avenard>
Severity: Normal CC: eric.carlson, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 223435    
Bug Blocks:    
Description Flags
Patch none

Description Jean-Yves Avenard [:jya] 2021-03-16 19:33:38 PDT
As in bug 223118 comment 17; we want to only send the image to the GPU process when the image actually changed to avoid unnecessary overhead.

We could deal with the check in the MediaSessionManagerCocoa so that the implementation details are removed from MediaElementSession.
Comment 1 Radar WebKit Bug Importer 2021-03-17 21:34:29 PDT
Comment 2 Jean-Yves Avenard [:jya] 2021-03-21 20:24:38 PDT
Created attachment 423846 [details]
Comment 3 Jean-Yves Avenard [:jya] 2021-03-21 20:25:56 PDT
Created attachment 423847 [details]
Comment 4 Jean-Yves Avenard [:jya] 2021-03-23 06:01:25 PDT
EWS failure (crash) doesn't appear to hit the code path touched by this change.
Comment 5 Eric Carlson 2021-03-23 08:47:49 PDT
Comment on attachment 423847 [details]

r=me once the bots are happy
Comment 6 EWS 2021-03-23 09:18:31 PDT
Committed r274873: <https://commits.webkit.org/r274873>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423847 [details].