Bug 22329

Summary: Improper bitwise and tests against 0 in Windows context menu code
Product: WebKit Reporter: Steve Falkenburg <sfalken>
Component: WebKit Misc.Assignee: Steve Falkenburg <sfalken>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows XP   
Attachments:
Description Flags
Fix bitwise ands against 0 sullivan: review+

Steve Falkenburg
Reported 2008-11-17 22:33:36 PST
Microsoft's PREfast static code analysis flagged: c:\cygwin\home\safari user\webkit\opensource\webcore\platform\win\contextmenuitemwin.cpp(106) : warning C6313: Incorrect operator: zero-valued flag cannot be tested with bitwise-and. Use an equality test to check for zero-valued flags c:\cygwin\home\safari user\webkit\opensource\webcore\platform\win\contextmenuitemwin.cpp(190) : warning C6313: Incorrect operator: zero-valued flag cannot be tested with bitwise-and. Use an equality test to check for zero-valued flags
Attachments
Fix bitwise ands against 0 (1.53 KB, patch)
2008-11-17 22:40 PST, Steve Falkenburg 		sullivan: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Steve Falkenburg
Comment 1 2008-11-17 22:40:17 PST
Created attachment 25231 [details] Fix bitwise ands against 0
Steve Falkenburg
Comment 2 2008-11-18 11:50:07 PST
Fixed in r38565
Note You need to log in before you can comment on or make changes to this bug.