Bug 22329

Summary: Improper bitwise and tests against 0 in Windows context menu code
Product: WebKit Reporter: Steve Falkenburg <sfalken>
Component: WebKit Misc.Assignee: Steve Falkenburg <sfalken>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows XP   
Attachments:
Description Flags
Fix bitwise ands against 0 sullivan: review+

Description Steve Falkenburg 2008-11-17 22:33:36 PST 
Microsoft's PREfast static code analysis flagged:

c:\cygwin\home\safari user\webkit\opensource\webcore\platform\win\contextmenuitemwin.cpp(106) : warning C6313: Incorrect operator: zero-valued flag cannot be tested with bitwise-and. Use an equality test to check for zero-valued flags
c:\cygwin\home\safari user\webkit\opensource\webcore\platform\win\contextmenuitemwin.cpp(190) : warning C6313: Incorrect operator: zero-valued flag cannot be tested with bitwise-and. Use an equality test to check for zero-valued flags
Comment 1 Steve Falkenburg 2008-11-17 22:40:17 PST 
Created attachment 25231 [details]
Fix bitwise ands against 0
Comment 2 Steve Falkenburg 2008-11-18 11:50:07 PST 
Fixed in r38565