Bug 223282

Summary: REGRESSION (r274460): [macOS] TestWebKitAPI.Fullscreen.WKViewDelegate is timing out
Product: WebKit Reporter: Amir Mark Jr <amir_mark>
Component: New BugsAssignee: Jean-Yves Avenard [:jya] <jean-yves.avenard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, darin, jean-yves.avenard, jer.noble, tsavell, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
ews-feeder: commit-queue-
Patch none

Amir Mark Jr
Reported 2021-03-16 14:49:05 PDT
TestWebKitAPI.Fullscreen.WKViewDelegate is timing out on Catalina, Big Sur and Big Sur Apple Silicon https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.Fullscreen.WKViewDelegate https://build.webkit.org/#/builders/48/builds/1076/steps/11/logs/stdio
Attachments
Patch (4.52 KB, patch)
2021-05-14 04:06 PDT, Jean-Yves Avenard [:jya] 		no flags
DetailsFormatted DiffDiff
Patch (3.73 KB, patch)
2021-05-27 22:11 PDT, Jean-Yves Avenard [:jya] 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (4.12 KB, patch)
2021-05-27 23:01 PDT, Jean-Yves Avenard [:jya] 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-03-16 14:49:27 PDT
<rdar://problem/75495585>
Amir Mark Jr
Comment 2 2021-03-16 15:10:32 PDT
Regression point related to: https://trac.webkit.org/changeset/274460/webkit
Ryan Haddad
Comment 3 2021-03-17 09:40:52 PDT
Jer is going to look at this today. We will disable the test for now.
Amir Mark Jr
Comment 4 2021-03-17 11:22:42 PDT
Disabled API test: https://trac.webkit.org/changeset/274572/webkit
Jean-Yves Avenard [:jya]
Comment 5 2021-05-14 04:06:58 PDT
Created attachment 428616 [details] Patch
Jean-Yves Avenard [:jya]
Comment 6 2021-05-14 04:08:13 PDT
*** Bug 225802 has been marked as a duplicate of this bug. ***
EWS
Comment 7 2021-05-14 15:18:14 PDT
Committed r277508 (237739@main): <https://commits.webkit.org/237739@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428616 [details].
Truitt Savell
Comment 8 2021-05-21 10:44:43 PDT
This test is still timing out now that is has been reenabled: https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.Fullscreen.WKViewDelegate
Jean-Yves Avenard [:jya]
Comment 9 2021-05-27 22:11:57 PDT
Created attachment 429984 [details] Patch
Jean-Yves Avenard [:jya]
Comment 10 2021-05-27 23:01:22 PDT
Created attachment 429990 [details] Patch Removed no longer used method
Darin Adler
Comment 11 2021-05-29 22:46:17 PDT
We could do one better by removing the underlying feature entirely so no one can use it even by accident.
EWS
Comment 12 2021-05-30 04:43:56 PDT
Committed r278252 (238289@main): <https://commits.webkit.org/238289@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429990 [details].
Note You need to log in before you can comment on or make changes to this bug.