Bug 223282

Summary: REGRESSION (r274460): [macOS] TestWebKitAPI.Fullscreen.WKViewDelegate is timing out
Product: WebKit Reporter: Amir Mark Jr <amir_mark>
Component: New BugsAssignee: Jean-Yves Avenard [:jya] <jean-yves.avenard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, darin, jean-yves.avenard, jer.noble, tsavell, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
ews-feeder: commit-queue-
Patch none

Description Amir Mark Jr 2021-03-16 14:49:05 PDT 
TestWebKitAPI.Fullscreen.WKViewDelegate is timing out on Catalina, Big Sur and Big Sur Apple Silicon 

https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.Fullscreen.WKViewDelegate

https://build.webkit.org/#/builders/48/builds/1076/steps/11/logs/stdio
Comment 1 Radar WebKit Bug Importer 2021-03-16 14:49:27 PDT 
<rdar://problem/75495585>
Comment 2 Amir Mark Jr 2021-03-16 15:10:32 PDT 
Regression point related to: https://trac.webkit.org/changeset/274460/webkit
Comment 3 Ryan Haddad 2021-03-17 09:40:52 PDT 
Jer is going to look at this today. We will disable the test for now.
Comment 4 Amir Mark Jr 2021-03-17 11:22:42 PDT 
Disabled API test:

https://trac.webkit.org/changeset/274572/webkit
Comment 5 Jean-Yves Avenard [:jya] 2021-05-14 04:06:58 PDT 
Created attachment 428616 [details]
Patch
Comment 6 Jean-Yves Avenard [:jya] 2021-05-14 04:08:13 PDT 
*** Bug 225802 has been marked as a duplicate of this bug. ***
Comment 7 EWS 2021-05-14 15:18:14 PDT 
Committed r277508 (237739@main): <https://commits.webkit.org/237739@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428616 [details].
Comment 8 Truitt Savell 2021-05-21 10:44:43 PDT 
This test is still timing out now that is has been reenabled:
https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.Fullscreen.WKViewDelegate
Comment 9 Jean-Yves Avenard [:jya] 2021-05-27 22:11:57 PDT 
Created attachment 429984 [details]
Patch
Comment 10 Jean-Yves Avenard [:jya] 2021-05-27 23:01:22 PDT 
Created attachment 429990 [details]
Patch

Removed no longer used method
Comment 11 Darin Adler 2021-05-29 22:46:17 PDT 
We could do one better by removing the underlying feature entirely so no one can use it even by accident.
Comment 12 EWS 2021-05-30 04:43:56 PDT 
Committed r278252 (238289@main): <https://commits.webkit.org/238289@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429990 [details].