Summary: | Avoid heap allocation under AudioDestinationCocoa::render() | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||||
Component: | Web Audio | Assignee: | Chris Dumez <cdumez> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | calvaris, cdumez, darin, eric.carlson, ews-watchlist, ggaren, glenn, jer.noble, peng.liu6, philipj, pnormand, sam, sergio, vjaquez, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=223840 | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 223226 | ||||||||||||
Attachments: |
|
Description
Chris Dumez
2021-03-16 12:45:40 PDT
Created attachment 423382 [details]
Patch
Created attachment 423391 [details]
Patch
Created attachment 423393 [details]
Patch
Comment on attachment 423393 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423393&action=review > Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:407 > if (!locker || !priv->dispatchToRenderThreadFunction) Do we need to do the same thing for GStreamer port as for Cocoa here? Comment on attachment 423393 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423393&action=review >> Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:407 >> if (!locker || !priv->dispatchToRenderThreadFunction) > > Do we need to do the same thing for GStreamer port as for Cocoa here? Oh, I missed that. Thanks. Created attachment 423394 [details]
Patch
Committed r274527: <https://commits.webkit.org/r274527> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423394 [details]. |