Bug 223272 – Avoid heap allocation under AudioDestinationCocoa::render()

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Audio

[Chris Dumez]

Avoid heap allocation under AudioDestinationCocoa::render():
Thread 9 Crashed:: RemoteAudioDestinationProxy render thread
0   com.apple.JavaScriptCore            0x0000000527c4bb6e WTFCrash + 14 (Assertions.cpp:295)
1   com.apple.JavaScriptCore            0x00000005293e893b WTFCrashWithInfo(int, char const*, char const*, int) + 27 (Assertions.h:671)
2   com.apple.JavaScriptCore            0x0000000527c892f7 WTF::fastMalloc(unsigned long) + 215 (FastMalloc.cpp:512)
3   com.apple.WebCore                   0x00000005088cc075 WTF::Detail::CallableWrapperBase<void>::operator new(unsigned long) + 21 (Function.h:37)
4   com.apple.WebCore                   0x000000050c80418b std::__1::__unique_if<WTF::Detail::CallableWrapper<WebCore::AudioDestinationCocoa::render(double, unsigned long long, unsigned int, AudioBufferList*)::$_19, void> >::__unique_single std::__1::make_unique<WTF::Detail::CallableWrapper<WebCore::AudioDestinationCocoa::render(double, unsigned long long, unsigned int, AudioBufferList*)::$_19, void>, WebCore::AudioDestinationCocoa::render(double, unsigned long long, unsigned int, AudioBufferList*)::$_19>(WebCore::AudioDestinationCocoa::render(double, unsigned long long, unsigned int, AudioBufferList*)::$_19&&) + 43 (memory:2755)
5   com.apple.WebCore                   0x000000050c8040f6 decltype(auto) WTF::makeUnique<WTF::Detail::CallableWrapper<WebCore::AudioDestinationCocoa::render(double, unsigned long long, unsigned int, AudioBufferList*)::$_19, void>, WebCore::AudioDestinationCocoa::render(double, unsigned long long, unsigned int, AudioBufferList*)::$_19>(WebCore::AudioDestinationCocoa::render(double, unsigned long long, unsigned int, AudioBufferList*)::$_19&&) + 54 (StdLibExtras.h:507)
6   com.apple.WebCore                   0x000000050c8040a0 WTF::Function<void ()>::Function<WebCore::AudioDestinationCocoa::render(double, unsigned long long, unsigned int, AudioBufferList*)::$_19, void>(WebCore::AudioDestinationCocoa::render(double, unsigned long long, unsigned int, AudioBufferList*)::$_19&&) + 48 (Function.h:74)
7   com.apple.WebCore                   0x000000050c7fdb3d WTF::Function<void ()>::Function<WebCore::AudioDestinationCocoa::render(double, unsigned long long, unsigned int, AudioBufferList*)::$_19, void>(WebCore::AudioDestinationCocoa::render(double, unsigned long long, unsigned int, AudioBufferList*)::$_19&&) + 29 (Function.h:74)
8   com.apple.WebCore                   0x000000050c7fd7f3 WebCore::AudioDestinationCocoa::render(double, unsigned long long, unsigned int, AudioBufferList*) + 659 (AudioDestinationCocoa.cpp:229)
9   com.apple.WebKit                    0x00000004f9bd89ea WebKit::RemoteAudioDestinationProxy::renderQuantum() + 250 (RemoteAudioDestinationProxy.cpp:166)
10  com.apple.WebKit                    0x00000004f9c0166f WebKit::RemoteAudioDestinationProxy::startRenderingThread()::$_10::operator()() + 95 (RemoteAudioDestinationProxy.cpp:87)
11  com.apple.WebKit                    0x00000004f9c015de WTF::Detail::CallableWrapper<WebKit::RemoteAudioDestinationProxy::startRenderingThread()::$_10, void>::call() + 30 (Function.h:52)
12  com.apple.JavaScriptCore            0x0000000527c74172 WTF::Function<void ()>::operator()() const + 130 (Function.h:83)
13  com.apple.JavaScriptCore            0x0000000527d28948 WTF::Thread::entryPoint(WTF::Thread::NewThreadContext*) + 424 (Threading.cpp:181)
14  com.apple.JavaScriptCore            0x0000000527d34ae8 WTF::wtfThreadEntryPoint(void*) + 24 (ThreadingPOSIX.cpp:241)
15  libsystem_pthread.dylib             0x00007fff20686954 _pthread_start + 224
16  libsystem_pthread.dylib             0x00007fff206824a7 thread_start + 15

[Chris Dumez]

Created attachment 423382 [details]
Patch

[Chris Dumez]

Created attachment 423391 [details]
Patch

[Chris Dumez]

Created attachment 423393 [details]
Patch

[Peng Liu]

Comment on attachment 423393 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423393&action=review

> Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:407
>      if (!locker || !priv->dispatchToRenderThreadFunction)

Do we need to do the same thing for GStreamer port as for Cocoa here?

[Chris Dumez]

Comment on attachment 423393 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423393&action=review

>> Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:407
>>      if (!locker || !priv->dispatchToRenderThreadFunction)
> 
> Do we need to do the same thing for GStreamer port as for Cocoa here?

Oh, I missed that. Thanks.

[Chris Dumez]

Created attachment 423394 [details]
Patch

[EWS]

Committed r274527: <https://commits.webkit.org/r274527>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423394 [details].

[Radar WebKit Bug Importer]

<rdar://problem/75498622>