Bug 223248 – Apply permission policy to geolocation

• Component: DOM
• Status: RESOLVED FIXED

[youenn fablet]

Apply permission policy to geolocation

[youenn fablet]

Created attachment 423316 [details]
Patch

[youenn fablet]

Created attachment 423328 [details]
Patch

[Eric Carlson]

Comment on attachment 423328 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423328&action=review

> Source/WebCore/Modules/geolocation/Geolocation.cpp:358
> +    if (!isFeaturePolicyAllowedByDocumentAndAllOwners(FeaturePolicy::Type::Geolocation, *document(), LogFeaturePolicyFailure::Yes))
> +        return true;

As we discussed, I think a linked-on-or-after check would be a good idea so we don't break existing apps that depend on the old behavior.

[youenn fablet]

> As we discussed, I think a linked-on-or-after check would be a good idea so
> we don't break existing apps that depend on the old behavior.

If we add a linked-on-or-after check here, we probably need to do the same when computing the origin shown on the geolocation prompt.
We can probably do that, but maybe we can try to land this change and use linked-on-or-after if we see breakage?

[Radar WebKit Bug Importer]

<rdar://problem/75732512>

[EWS]

Tools/Scripts/svn-apply failed to apply attachment 423328 [details] to trunk.
Please resolve the conflicts and upload a new patch.

[youenn fablet]

Created attachment 424637 [details]
Patch for landing

[EWS]

Committed r275276: <https://commits.webkit.org/r275276>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 424637 [details].