Bug 22323
| Summary: | Enable pixel tests by default on Mac | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Pierre-Olivier Latour <pol> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | mitz, mjs |
| Priority: | P4 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Mac | ||
| OS: | OS X 10.5 | ||
| Bug Depends on: | 22271 | ||
| Bug Blocks: | |||
Pierre-Olivier Latour
Following a discussion on IRC, we should figure out if we want to enable pixel tests by default on Mac
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Pierre-Olivier Latour
First of all, it would be for Mac and OS X Leopard only for now:
- on other platforms, pixel tests aren't really supported
- on Tiger, too many images slightly differ (because of very minor differences in font rendering), which makes the fast hash comparison fail, and require ImageDiff to run and slows down everything
Pierre-Olivier Latour
r38525 build debug on iMac Intel w/ 10.5.4:
- /LayoutTests w/ pixel tests disabled: 474.57s
- /LayoutTests w/ pixel tests enabled: 561.61s (+18.3%)
- /LayoutTests/fast w/ pixel tests disabled: 140.98s
- /LayoutTests/fast w/ pixel tests enabled: 157.22s (+11.5%)
Pierre-Olivier Latour
Second run on /LayoutTests:using the same configuration:
- pixel tests disabled: 497.92s
= pixel tests enabled: 565.44s (+13.5%)
Pierre-Olivier Latour
Some other stats using r38600 Release on a Mac Book Pro with 10.5.4:
- /LayoutTests w/ pixel tests disabled: 555.34s
- /LayoutTests w/ pixel tests enabled: 601.47s (+8.3%)
It'd be good to have data on a PPC machine as there can be minor differences in CG rendering, then we should have all the needed info to decide!