| Summary: | Ignore the “title” argument to history.pushState()/history.replaceState() | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Domenic Denicola <d> |
| Component: | History | Assignee: | sideshowbarker <mike> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ahmad.saleem792, annevk, beidson, mike, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
|
Description
Domenic Denicola
2021-03-15 10:02:49 PDT
Pull request: https://github.com/WebKit/WebKit/pull/20404 Committed 273650@main (4ef4b65d33f4): <https://commits.webkit.org/273650@main> Reviewed commits have been landed. Closing PR #20404 and removing active labels. This patch is wrong, as it entirely removed the concept of "title" from WebBackForwardItem, causing a regression in Safari.
- (NSString *)title
{
return nil;
}
Domenic mentioned:
> Only Safari (maybe other WebKit browsers?) uses this for its UI.
And what he meant was only Safari takes title updates from push/replaceState calls from JavaScript.
All browsers still show the page title at the time the page was loaded; just verified with latest Chrome and Firefox.
This patch needed to focus on *not updating the title in a bfitem* instead of removing the concept altogether.
|