Bug 223190 – Ignore the “title” argument to history.pushState()/history.replaceState()

• Status: RESOLVED
• Resolution: FIXED
• Component: History

[Domenic Denicola]

Only Safari (maybe other WebKit browsers?) uses this for its UI. Since it only impacts UI, and only in one browser, it was removed from the spec in https://github.com/whatwg/html/pull/6482.

Continuing to support title for these functions is not a spec violation, since browser UI is outside the scope of specs (i.e. web pages cannot observe Safari's use of the title argument). But, you might want to clean it up regardless. Especially if web developers only test in other browsers, and so pass strange values (e.g. "null" or similar) which Safari ends up displaying to users.

[Radar WebKit Bug Importer]

<rdar://problem/75695791>

[Ahmad Saleem]

https://html.spec.whatwg.org/multipage/nav-history-apis.html#the-history-interface

[sideshowbarker]

Pull request: https://github.com/WebKit/WebKit/pull/20404

[EWS]

Committed 273650@main (4ef4b65d33f4): <https://commits.webkit.org/273650@main>

Reviewed commits have been landed. Closing PR #20404 and removing active labels.

[Brady Eidson]

This patch is wrong, as it entirely removed the concept of "title" from WebBackForwardItem, causing a regression in Safari.

- (NSString *)title
{
    return nil;
}

Domenic mentioned:
> Only Safari (maybe other WebKit browsers?) uses this for its UI.

And what he meant was only Safari takes title updates from push/replaceState calls from JavaScript.

All browsers still show the page title at the time the page was loaded; just verified with latest Chrome and Firefox.

This patch needed to focus on *not updating the title in a bfitem* instead of removing the concept altogether.