Bug 223179

Summary: Move instanced drawing functionality from ExtensionsGL to GraphicsContextGL
Product: WebKit Reporter: Kimmo Kinnunen <kkinnunen>
Component: WebGLAssignee: Kimmo Kinnunen <kkinnunen>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, kbr, kkinnunen, pnormand, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 223633    
Bug Blocks: 221664    
Attachments:
Description Flags
Patch none

Kimmo Kinnunen
Reported 2021-03-15 05:44:23 PDT
Move instanced drawing functionality from ExtensionsGL to GraphicsContextGL ExtensionsGL never fulfilled its purpose. Currently it is equivalent to corresponding GraphicsContextGL instance. This just complicates the implementation.
Attachments
Patch (12.71 KB, patch)
2021-03-22 04:41 PDT, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kimmo Kinnunen
Comment 1 2021-03-22 04:41:02 PDT
Created attachment 423871 [details] Patch
Radar WebKit Bug Importer
Comment 2 2021-03-22 05:45:13 PDT
<rdar://problem/75687036>
Kenneth Russell
Comment 3 2021-03-22 16:09:41 PDT
Comment on attachment 423871 [details] Patch Looks good to delete this unused code. r+
EWS
Comment 4 2021-03-23 01:42:17 PDT
commit-queue failed to commit attachment 423871 [details] to WebKit repository. To retry, please set cq+ flag again.
EWS
Comment 5 2021-03-23 03:57:20 PDT
Committed r274860: <https://commits.webkit.org/r274860> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423871 [details].
Philippe Normand
Comment 6 2021-03-23 05:12:29 PDT
This broke the WPE build...
Kimmo Kinnunen
Comment 7 2021-03-23 05:16:26 PDT
(In reply to Philippe Normand from comment #6) > This broke the WPE build... Sorry. I'll check.
Philippe Normand
Comment 8 2021-03-23 05:20:12 PDT
This is what I have so far: http://sprunge.us/ZTnlLR
Philippe Normand
Comment 9 2021-03-23 05:32:54 PDT
(In reply to Philippe Normand from comment #8) > This is what I have so far: http://sprunge.us/ZTnlLR Not good :)
Kimmo Kinnunen
Comment 10 2021-03-23 05:34:06 PDT
tracked in bug 223633
Note You need to log in before you can comment on or make changes to this bug.