Bug 223167

Summary: WebGL should be aware of [AllowShared]
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: WebGLAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, dino, esprehn+autocc, ews-watchlist, graouts, gyuyoung.kim, hi, kbr, kkinnunen, kondapallykalyan, mehdisabwat, oleksandr.chekhovskyi, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Yusuke Suzuki
Reported 2021-03-14 16:12:42 PDT
We should attach [AllowShared].
Attachments
Patch (15.46 KB, patch)
2021-03-14 16:16 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (19.50 KB, patch)
2021-03-15 10:01 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (20.73 KB, patch)
2021-03-15 10:43 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2021-03-14 16:16:48 PDT
Created attachment 423136 [details] Patch
Kimmo Kinnunen
Comment 2 2021-03-14 23:51:50 PDT
What does it do?
Yusuke Suzuki
Comment 3 2021-03-15 10:01:27 PDT
Created attachment 423190 [details] Patch
Yusuke Suzuki
Comment 4 2021-03-15 10:02:54 PDT
(In reply to Kimmo Kinnunen from comment #2) > What does it do? Attaching [AllowShared] annotations to WebGL types to align them to the spec. This [AllowShared] annotation allows these WebGL functions to accept ArrayBuffer / ArrayBufferView created from SharedArrayBuffer. By default, non-allow-shared ArrayBuffer etc. is rejected and throws TypeError. But when [AllowShared] annotation is attached, IDL can accept them.
Yusuke Suzuki
Comment 5 2021-03-15 10:05:24 PDT
We found that this is used in apps using wasm-threads and WebGL. https://twitter.com/Constellation/status/1371507429683302403
Yusuke Suzuki
Comment 6 2021-03-15 10:43:44 PDT
Created attachment 423198 [details] Patch
Kimmo Kinnunen
Comment 7 2021-03-15 12:51:52 PDT
Thanks, had missed the feature. Looks good to me. We don't have the tests for these, I'm in process of importing new set of tests from WebGL conformance test suite that should then add some test coverage.
Saam Barati
Comment 8 2021-03-15 13:18:36 PDT
Comment on attachment 423198 [details] Patch rs=me
Yusuke Suzuki
Comment 9 2021-03-15 13:21:42 PDT
(In reply to Kimmo Kinnunen from comment #7) > Thanks, had missed the feature. > Looks good to me. > We don't have the tests for these, I'm in process of importing new set of > tests from WebGL conformance test suite that should then add some test > coverage. Thanks! The added test LayoutTests/webgl/webgl-allow-shared.html covers it too :)
EWS
Comment 10 2021-03-15 13:50:00 PDT
Committed r274438: <https://commits.webkit.org/r274438> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423198 [details].
Radar WebKit Bug Importer
Comment 11 2021-03-15 13:51:17 PDT
<rdar://problem/75445318>
Kenneth Russell
Comment 12 2021-06-21 17:42:19 PDT
*** Bug 227117 has been marked as a duplicate of this bug. ***
Yusuke Suzuki
Comment 13 2021-09-09 03:33:48 PDT
*** Bug 173599 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.