Summary: | WebGL should be aware of [AllowShared] | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||||||
Component: | WebGL | Assignee: | Yusuke Suzuki <ysuzuki> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | cdumez, changseok, dino, esprehn+autocc, ews-watchlist, graouts, gyuyoung.kim, hi, kbr, kkinnunen, kondapallykalyan, mehdisabwat, oleksandr.chekhovskyi, saam, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Yusuke Suzuki
2021-03-14 16:12:42 PDT
Created attachment 423136 [details]
Patch
What does it do? Created attachment 423190 [details]
Patch
(In reply to Kimmo Kinnunen from comment #2) > What does it do? Attaching [AllowShared] annotations to WebGL types to align them to the spec. This [AllowShared] annotation allows these WebGL functions to accept ArrayBuffer / ArrayBufferView created from SharedArrayBuffer. By default, non-allow-shared ArrayBuffer etc. is rejected and throws TypeError. But when [AllowShared] annotation is attached, IDL can accept them. We found that this is used in apps using wasm-threads and WebGL. https://twitter.com/Constellation/status/1371507429683302403 Created attachment 423198 [details]
Patch
Thanks, had missed the feature. Looks good to me. We don't have the tests for these, I'm in process of importing new set of tests from WebGL conformance test suite that should then add some test coverage. Comment on attachment 423198 [details]
Patch
rs=me
(In reply to Kimmo Kinnunen from comment #7) > Thanks, had missed the feature. > Looks good to me. > We don't have the tests for these, I'm in process of importing new set of > tests from WebGL conformance test suite that should then add some test > coverage. Thanks! The added test LayoutTests/webgl/webgl-allow-shared.html covers it too :) Committed r274438: <https://commits.webkit.org/r274438> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423198 [details]. *** Bug 227117 has been marked as a duplicate of this bug. *** *** Bug 173599 has been marked as a duplicate of this bug. *** |