Bug 223145

Summary:

Adopt DDMacAction instead of DDAction on macOS

Product:

WebKit

Reporter:

Tim Horton <thorton>

Component:

New Bugs

Assignee:

Tim Horton <thorton>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cdumez, cmarcelo, darin, ews-watchlist, megan_gardner, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Tim Horton 2021-03-12 16:14:35 PST

Adopt DDMacAction instead of DDAction on macOS

Comment 1 Tim Horton 2021-03-12 16:15:06 PST

Created attachment 423090 [details]
Patch

Comment 2 Tim Horton 2021-03-12 16:15:08 PST

<rdar://problem/70127512>

Comment 3 Darin Adler 2021-03-12 16:38:21 PST

Comment on attachment 423090 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423090&action=review

> Source/WebCore/PAL/pal/spi/mac/DataDetectorsSPI.h:108
>  @property (readonly) NSString *actionUTI;

Do we need something that declares -[DDMacAction actionUTI] for the non-Apple-internal-SDK case?

Comment 4 Tim Horton 2021-03-12 16:52:51 PST

(In reply to Darin Adler from comment #3)
> Comment on attachment 423090 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=423090&action=review
> 
> > Source/WebCore/PAL/pal/spi/mac/DataDetectorsSPI.h:108
> >  @property (readonly) NSString *actionUTI;
> 
> Do we need something that declares -[DDMacAction actionUTI] for the
> non-Apple-internal-SDK case?

We do... eventually, when we need to support HAVE_DATA_DETECTORS_MAC_ACTION in open source builds. See 70127512 for why this is currently not possible.

Comment 5 EWS 2021-03-12 21:26:03 PST

commit-queue failed to commit attachment 423090 [details] to WebKit repository. To retry, please set cq+ flag again.

Comment 6 EWS 2021-03-13 01:03:09 PST

Committed r274380: <https://commits.webkit.org/r274380>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423090 [details].