RESOLVED FIXED 223145
Adopt DDMacAction instead of DDAction on macOS 
https://bugs.webkit.org/show_bug.cgi?id=223145
Summary Adopt DDMacAction instead of DDAction on macOS
Tim Horton
Reported 2021-03-12 16:14:35 PST
Adopt DDMacAction instead of DDAction on macOS
Attachments
Patch (7.49 KB, patch)
2021-03-12 16:15 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2021-03-12 16:15:06 PST
Created attachment 423090 [details] Patch
Tim Horton
Comment 2 2021-03-12 16:15:08 PST
<rdar://problem/70127512>
Darin Adler
Comment 3 2021-03-12 16:38:21 PST
Comment on attachment 423090 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423090&action=review > Source/WebCore/PAL/pal/spi/mac/DataDetectorsSPI.h:108 > @property (readonly) NSString *actionUTI; Do we need something that declares -[DDMacAction actionUTI] for the non-Apple-internal-SDK case?
Tim Horton
Comment 4 2021-03-12 16:52:51 PST
(In reply to Darin Adler from comment #3) > Comment on attachment 423090 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=423090&action=review > > > Source/WebCore/PAL/pal/spi/mac/DataDetectorsSPI.h:108 > > @property (readonly) NSString *actionUTI; > > Do we need something that declares -[DDMacAction actionUTI] for the > non-Apple-internal-SDK case? We do... eventually, when we need to support HAVE_DATA_DETECTORS_MAC_ACTION in open source builds. See 70127512 for why this is currently not possible.
EWS
Comment 5 2021-03-12 21:26:03 PST
commit-queue failed to commit attachment 423090 [details] to WebKit repository. To retry, please set cq+ flag again.
EWS
Comment 6 2021-03-13 01:03:09 PST
Committed r274380: <https://commits.webkit.org/r274380> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423090 [details].
Note You need to log in before you can comment on or make changes to this bug.