| Summary: | [css-flexbox] Fix incorrect relative path | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Rob Buis <rbuis> | ||||||||||||
| Component: | CSS | Assignee: | Rob Buis <rbuis> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | aakash_jain, clopez, darin, ews-watchlist, webkit-bug-importer, youennf | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Rob Buis
2021-03-12 06:36:23 PST
Created attachment 423042 [details]
Patch
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess Comment on attachment 423042 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423042&action=review > LayoutTests/imported/w3c/ChangeLog:9 > + Fix incorrect relative path, because of this the comparisons > + were not accurate, causing failures where the rendering was correct. What made those paths wrong? The import script, or somehow something in the WPT original? If it was the import script, where is the fix to the script> If it’s in the WPT original, are we submitting a pull request for WPT? commit-queue failed to commit attachment 423042 [details] to WebKit repository. To retry, please set cq+ flag again.
Comment on attachment 423042 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423042&action=review >> LayoutTests/imported/w3c/ChangeLog:9 >> + were not accurate, causing failures where the rendering was correct. > > What made those paths wrong? The import script, or somehow something in the WPT original? > > If it was the import script, where is the fix to the script> I did a new import and the path is fine after importing, so this is likely a hand edited error, note some tests do need ../support/flexbox.css include path. I did not catch this in review, I guess next review I will look closer at expected results and image failures. It would be nice if we could find these problems through file not found tracking or so.... I am sure there are more cases like these in the big test repo. commit-queue failed to commit attachment 423042 [details] to WebKit repository. To retry, please set cq+ flag again.
Created attachment 423097 [details]
Patch
commit-queue failed to commit attachment 423097 [details] to WebKit repository. To retry, please set cq+ flag again.
Created attachment 423098 [details]
Patch
commit-queue failed to commit attachment 423098 [details] to WebKit repository. To retry, please set cq+ flag again.
Created attachment 423100 [details]
Patch
Found 1 new test failure: http/tests/security/referrer-policy-header.html commit-queue failed to commit attachment 423100 [details] to WebKit repository. To retry, please set cq+ flag again.
Created attachment 423101 [details]
Patch
commit-queue failed to commit attachment 423101 [details] to WebKit repository. To retry, please set cq+ flag again.
Committed r274389: <https://commits.webkit.org/r274389> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423101 [details]. |