RESOLVED FIXED223120
[css-flexbox] Fix incorrect relative path 
https://bugs.webkit.org/show_bug.cgi?id=223120
Summary [css-flexbox] Fix incorrect relative path
Rob Buis
Reported 2021-03-12 06:36:23 PST
Fix incorrect relative path.
Attachments
Patch (10.50 KB, patch)
2021-03-12 06:39 PST, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (10.55 KB, patch)
2021-03-12 22:44 PST, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (10.55 KB, patch)
2021-03-12 23:37 PST, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (10.54 KB, patch)
2021-03-13 01:54 PST, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (10.53 KB, patch)
2021-03-13 05:36 PST, Rob Buis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2021-03-12 06:39:39 PST
Created attachment 423042 [details] Patch
EWS Watchlist
Comment 2 2021-03-12 06:40:45 PST
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Darin Adler
Comment 3 2021-03-12 17:13:24 PST
Comment on attachment 423042 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423042&action=review > LayoutTests/imported/w3c/ChangeLog:9 > + Fix incorrect relative path, because of this the comparisons > + were not accurate, causing failures where the rendering was correct. What made those paths wrong? The import script, or somehow something in the WPT original? If it was the import script, where is the fix to the script>
Darin Adler
Comment 4 2021-03-12 17:30:29 PST
If it’s in the WPT original, are we submitting a pull request for WPT?
EWS
Comment 5 2021-03-12 22:19:52 PST
commit-queue failed to commit attachment 423042 [details] to WebKit repository. To retry, please set cq+ flag again.
Rob Buis
Comment 6 2021-03-12 22:20:33 PST
Comment on attachment 423042 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423042&action=review >> LayoutTests/imported/w3c/ChangeLog:9 >> + were not accurate, causing failures where the rendering was correct. > > What made those paths wrong? The import script, or somehow something in the WPT original? > > If it was the import script, where is the fix to the script> I did a new import and the path is fine after importing, so this is likely a hand edited error, note some tests do need ../support/flexbox.css include path. I did not catch this in review, I guess next review I will look closer at expected results and image failures. It would be nice if we could find these problems through file not found tracking or so.... I am sure there are more cases like these in the big test repo.
EWS
Comment 7 2021-03-12 22:24:06 PST
commit-queue failed to commit attachment 423042 [details] to WebKit repository. To retry, please set cq+ flag again.
Rob Buis
Comment 8 2021-03-12 22:44:41 PST
Created attachment 423097 [details] Patch
EWS
Comment 9 2021-03-12 23:23:36 PST
commit-queue failed to commit attachment 423097 [details] to WebKit repository. To retry, please set cq+ flag again.
Rob Buis
Comment 10 2021-03-12 23:37:00 PST
Created attachment 423098 [details] Patch
EWS
Comment 11 2021-03-13 00:51:33 PST
commit-queue failed to commit attachment 423098 [details] to WebKit repository. To retry, please set cq+ flag again.
Rob Buis
Comment 12 2021-03-13 01:54:20 PST
Created attachment 423100 [details] Patch
EWS
Comment 13 2021-03-13 04:43:03 PST
Found 1 new test failure: http/tests/security/referrer-policy-header.html
EWS
Comment 14 2021-03-13 05:22:08 PST
commit-queue failed to commit attachment 423100 [details] to WebKit repository. To retry, please set cq+ flag again.
Rob Buis
Comment 15 2021-03-13 05:36:20 PST
Created attachment 423101 [details] Patch
EWS
Comment 16 2021-03-13 06:46:32 PST
commit-queue failed to commit attachment 423101 [details] to WebKit repository. To retry, please set cq+ flag again.
EWS
Comment 17 2021-03-13 08:26:26 PST
Committed r274389: <https://commits.webkit.org/r274389> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423101 [details].
Radar WebKit Bug Importer
Comment 18 2021-03-13 08:27:14 PST
<rdar://problem/75394992>
Note You need to log in before you can comment on or make changes to this bug.