Bug 223092

Summary: Use BinarySemaphore in callOnMainAndWait()
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Web Template FrameworkAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, ews-watchlist, ggaren, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2021-03-11 14:23:34 PST
Use BinarySemaphore in callOnMainAndWait() instead of a Condition, this simplifies the code a bit.
Attachments
Patch (3.22 KB, patch)
2021-03-11 14:25 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2021-03-11 14:25:24 PST
Created attachment 422971 [details] Patch
Geoffrey Garen
Comment 2 2021-03-11 14:27:15 PST
Comment on attachment 422971 [details] Patch r=me
EWS
Comment 3 2021-03-11 15:16:08 PST
commit-queue failed to commit attachment 422971 [details] to WebKit repository. To retry, please set cq+ flag again.
EWS
Comment 4 2021-03-11 15:21:32 PST
commit-queue failed to commit attachment 422971 [details] to WebKit repository. To retry, please set cq+ flag again.
EWS
Comment 5 2021-03-11 15:52:26 PST
commit-queue failed to commit attachment 422971 [details] to WebKit repository. To retry, please set cq+ flag again.
Chris Dumez
Comment 6 2021-03-11 15:54:23 PST
Comment on attachment 422971 [details] Patch Clearing flags on attachment: 422971 Committed r274304 (235198@main): <https://commits.webkit.org/235198@main>
Chris Dumez
Comment 7 2021-03-11 15:54:26 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2021-03-11 15:55:16 PST
<rdar://problem/75337063>
Yusuke Suzuki
Comment 9 2021-03-11 18:39:59 PST
I'm happy to see that BinarySemaphore is used to clean up these things!
Note You need to log in before you can comment on or make changes to this bug.