Bug 223091

Summary: [macOS] override the background color of PDF documents to match PDFKit
Product: WebKit Reporter: Devin Rousso <hi>
Component: PDFAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: hi, sumer, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
thorton: review+
Patch
hi: commit-queue+
Patch none

Description Devin Rousso 2021-03-11 14:17:08 PST 
.
Comment 1 Devin Rousso 2021-03-11 14:18:03 PST 
<rdar://problem/74584770>
Comment 2 Devin Rousso 2021-03-11 14:23:14 PST 
Created attachment 422969 [details]
Patch
Comment 3 Tim Horton 2021-03-11 14:26:01 PST 
Comment on attachment 422969 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422969&action=review

> Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:621
> +        // FIXME: <rdar://problem/75332948>

This should say what it's about, because many WebKit contributors can't read the radar.
Comment 4 Devin Rousso 2021-03-11 15:20:34 PST 
Created attachment 422980 [details]
Patch
Comment 5 Devin Rousso 2021-03-11 15:21:20 PST 
Created attachment 422982 [details]
Patch
Comment 6 EWS 2021-03-11 15:48:31 PST 
commit-queue failed to commit attachment 422982 [details] to WebKit repository. To retry, please set cq+ flag again.
Comment 7 EWS 2021-03-11 16:22:13 PST 
Committed r274310: <https://commits.webkit.org/r274310>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 422982 [details].