Bug 223091

Summary: [macOS] override the background color of PDF documents to match PDFKit
Product: WebKit Reporter: Devin Rousso <hi>
Component: PDFAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: hi, sumer, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
thorton: review+
Patch
hi: commit-queue+
Patch none

Devin Rousso
Reported 2021-03-11 14:17:08 PST
.
Attachments
Patch (2.39 KB, patch)
2021-03-11 14:23 PST, Devin Rousso 		thorton: review+
DetailsFormatted DiffDiff
Patch (2.46 KB, patch)
2021-03-11 15:20 PST, Devin Rousso 		hi: commit-queue+
DetailsFormatted DiffDiff
Patch (2.45 KB, patch)
2021-03-11 15:21 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2021-03-11 14:18:03 PST
<rdar://problem/74584770>
Devin Rousso
Comment 2 2021-03-11 14:23:14 PST
Created attachment 422969 [details] Patch
Tim Horton
Comment 3 2021-03-11 14:26:01 PST
Comment on attachment 422969 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=422969&action=review > Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:621 > + // FIXME: <rdar://problem/75332948> This should say what it's about, because many WebKit contributors can't read the radar.
Devin Rousso
Comment 4 2021-03-11 15:20:34 PST
Created attachment 422980 [details] Patch
Devin Rousso
Comment 5 2021-03-11 15:21:20 PST
Created attachment 422982 [details] Patch
EWS
Comment 6 2021-03-11 15:48:31 PST
commit-queue failed to commit attachment 422982 [details] to WebKit repository. To retry, please set cq+ flag again.
EWS
Comment 7 2021-03-11 16:22:13 PST
Committed r274310: <https://commits.webkit.org/r274310> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422982 [details].
Note You need to log in before you can comment on or make changes to this bug.