Bug 223078

Summary: [macCatalyst] media controls should have macOS styling and behavior
Product: WebKit Reporter: Devin Rousso <hi>
Component: MediaAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, cdumez, changseok, eric.carlson, esprehn+autocc, ews-watchlist, glenn, hi, jer.noble, joepeck, kondapallykalyan, pdr, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
eric.carlson: review+, ews-feeder: commit-queue-
Patch none

Description Devin Rousso 2021-03-11 10:33:20 PST 
.
Comment 1 Devin Rousso 2021-03-11 10:33:34 PST 
<rdar://problem/71857091>
Comment 2 Devin Rousso 2021-03-11 11:02:06 PST 
Created attachment 422946 [details]
Patch
Comment 3 Eric Carlson 2021-03-11 11:18:24 PST 
Comment on attachment 422946 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422946&action=review

> Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp:117
> +    return nullString();

ASSERT_NOT_REACHED()?
Comment 4 Devin Rousso 2021-03-11 11:20:24 PST 
Comment on attachment 422946 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422946&action=review

>> Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp:117
>> +    return nullString();
> 
> ASSERT_NOT_REACHED()?

Do other platforms also use modern media controls?  I wasn't sure so I left it as an unknown (which also matches the existing behavior).
Comment 5 Devin Rousso 2021-03-11 13:07:22 PST 
Created attachment 422958 [details]
Patch
Comment 6 EWS 2021-03-11 13:36:55 PST 
Committed r274299: <https://commits.webkit.org/r274299>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 422958 [details].