Summary: | [WPE] Qt API build failure on 2.31.90 | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Bastian Krause <bst> | ||||||||||
Component: | WPE WebKit | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | aperez, bugs-noreply, ews-watchlist, glenn, jbedard, m.felsch, pnormand | ||||||||||
Priority: | P2 | ||||||||||||
Version: | WebKit Local Build | ||||||||||||
Hardware: | Other | ||||||||||||
OS: | Linux | ||||||||||||
Attachments: |
|
Description
Bastian Krause
2021-03-11 08:02:54 PST
This is also broken in the latest stable wpewebkit 2.32.0. Created attachment 426400 [details]
Patch
This patch reverts the WTF usage since this code has nothing to do with webkit internals at all.
Comment on attachment 426400 [details]
Patch
LGTM. Can you add these files in a new allow-list for the style-checker? Should be in Tools/Scripts/webkitpy/style/checker.py
Yep, I can add those files. Created attachment 426421 [details]
Patch
This adds the style checker allow-list.
Comment on attachment 426421 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426421&action=review > Tools/Scripts/webkitpy/style/checker.py:167 > + os.path.join('Source', 'WebKit', 'UIProcess', 'API', 'wpe', 'qt')], I think this works only for files, not individual directories. (In reply to Philippe Normand from comment #6) > Comment on attachment 426421 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=426421&action=review > > > Tools/Scripts/webkitpy/style/checker.py:167 > > + os.path.join('Source', 'WebKit', 'UIProcess', 'API', 'wpe', 'qt')], > > I think this works only for files, not individual directories. I've tested it and saw no more errors after applying it. But.. My indent is wrong.. Damn I don't see how this failures are related to my commit Please fix the style EWS. The wincairo failure looks indeed unrelated. (In reply to Philippe Normand from comment #10) > Please fix the style EWS. The wincairo failure looks indeed unrelated. I followed the style within the checker.py list. Don't see what I did wrong. (In reply to Marco Felsch from comment #11) > (In reply to Philippe Normand from comment #10) > > Please fix the style EWS. The wincairo failure looks indeed unrelated. > > I followed the style within the checker.py list. Don't see what I did wrong. Me neither. This pep thing is quite pedantic. Anyway, the fix I found is to dedent all 4 lines by one space. No idea why: ([ # The WPE QT wrapper lib is not part of Webkit and therefore don't need to statically # link the WTF framwork. Instead it uses the standard alloc mechanism. os.path.join('Source', 'WebKit', 'UIProcess', 'API', 'wpe', 'qt')], ["-runtime/wtf_make_unique"]), You can run Tools/Scripts/check-webkit-style locally btw. Comment on attachment 426421 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426421&action=review > Tools/Scripts/webkitpy/style/checker.py:166 > + # link the WTF framwork. Instead it uses the standard alloc mechanism. And fix the framwork typo while you're at it ;) Created attachment 426535 [details]
Patch
Now the style is fixed :)
(In reply to Philippe Normand from comment #13) > Comment on attachment 426421 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=426421&action=review > > > Tools/Scripts/webkitpy/style/checker.py:166 > > + # link the WTF framwork. Instead it uses the standard alloc mechanism. > > And fix the framwork typo while you're at it ;) Did that as well. /Volumes/Data/worker/Commit-Queue/build/Source/WebKit/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Sorry for the noise but how is fixed that failure.. Comment on attachment 426535 [details]
Patch
You should have left the "Reviewed by OOPS" lines...
Created attachment 426547 [details]
Patch
Hopefully the last version...
commit-queue failed to commit attachment 426547 [details] to WebKit repository. To retry, please set cq+ flag again.
Committed r276308 (236790@main): <https://commits.webkit.org/236790@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426547 [details]. |