Bug 223043

Summary:

[ BigSur wk2 arm64 ] 4 webrtc/ Layout-tests are consistently timing out

Product:

WebKit

Reporter:

Robert Jenner <jenner>

Component:

WebRTC

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ayumi_kojima, ben_schwartz, eric.carlson, tsavell, webkit-bot-watchers-bugzilla, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=223074
https://bugs.webkit.org/show_bug.cgi?id=238104

Attachments:

Description	Flags
A file with all four diffs showing the timeouts.	none
Patch	none
Patch	none
Patch	none
Patch	ews-feeder: commit-queue-

Robert Jenner

Reported 2021-03-10 13:53:36 PST

The following four tests are consistently timing out on BigSur wk2 on Apple Silicon machines: webrtc/h264-high.html webrtc/multi-audio.html webrtc/multi-video.html webrtc/vp9-profile2.html History URL: https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&test=webrtc%2Fh264-high.html&test=webrtc%2Fmulti-audio.html&test=webrtc%2Fmulti-video.html&test=webrtc%2Fvp9-profile2.html&platform=mac It should be noted that the following two have failed consistently since they started running on Apple Silicon: webrtc/h264-high.html webrtc/vp9-profile2.html Whereas the other two below were flakey timing out since they started running on Apple Silicon, and become a constant timeout at r274156: webrtc/multi-audio.html webrtc/multi-video.html

Attachments
A file with all four diffs showing the timeouts. (4.27 KB, application/zip) 2021-03-10 13:56 PST, Robert Jenner	no flags	Details
Patch (1.52 KB, patch) 2021-06-29 16:53 PDT, ayumi_kojima	no flags	Details Formatted Diff Diff
Patch (1.93 KB, patch) 2021-06-29 17:06 PDT, ayumi_kojima	no flags	Details Formatted Diff Diff
Patch (2.39 KB, patch) 2022-03-14 03:51 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (2.38 KB, patch) 2022-03-14 03:52 PDT, youenn fablet	ews-feeder: commit-queue-	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2021-03-10 13:53:54 PST

<rdar://problem/75280718>

Robert Jenner

Comment 2 2021-03-10 13:56:48 PST

Created attachment 422867 [details] A file with all four diffs showing the timeouts. I'm attaching all four diffs to this bug. Other than showing the timeout, I'm not certain how helpful they will be.

Robert Jenner

Comment 3 2021-03-10 13:57:13 PST

I cannot reproduce these timeouts because I do not have access to an Apple Silicon system.

Robert Jenner

Comment 4 2021-03-16 09:46:46 PDT

While we are deciding on a fix for these tests, I have updated the test expectations for them and a few other webrtc tests that are having issues only on Apple Silicon Macs. https://trac.webkit.org/changeset/274484/webkit

Robert Jenner

Comment 5 2021-03-16 14:02:24 PDT

One test started timing out constantly when marked as Failure. So I updated the test expectations to include Failure Timeout here: https://trac.webkit.org/changeset/274514/webkit

Robert Jenner

Comment 6 2021-04-12 17:47:13 PDT

Added crash expectation to "webrtc/multi-audio.html" while test is under review: https://trac.webkit.org/changeset/275851/webkit

ayumi_kojima

Comment 7 2021-06-29 16:37:11 PDT

webrtc/multi-audio.html Seems like this test is now flaky failing on BigSur

ayumi_kojima

Comment 8 2021-06-29 16:53:47 PDT

Created attachment 432555 [details] Patch

ayumi_kojima

Comment 9 2021-06-29 17:06:08 PDT

Created attachment 432557 [details] Patch

Truitt Savell

Comment 10 2021-06-29 17:09:10 PDT

Comment on attachment 432557 [details] Patch Clearing flags on attachment: 432557 Committed r279396 (239261@main): <https://commits.webkit.org/239261@main>

youenn fablet

Comment 11 2022-03-14 03:51:37 PDT

Created attachment 454573 [details] Patch

youenn fablet

Comment 12 2022-03-14 03:52:29 PDT

Created attachment 454574 [details] Patch

EWS

Comment 13 2022-03-14 04:29:00 PDT

Committed r291221 (248376@main): <https://commits.webkit.org/248376@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 454574 [details].

Ryan Haddad

Comment 14 2022-03-18 16:28:47 PDT

webrtc/vp9-profile2.html is still a consistent timeout on arm64 bots after it was un-skipped: https://results.webkit.org/?suite=layout-tests&test=webrtc/vp9-profile2.html

Ben Schwartz

Comment 15 2024-05-31 17:05:54 PDT

This no longer appears to be occurring. Removing test expectations. Please file a new bug if issues persist. Tracking test expectations removal in bug #274990 (rdar://129080660).

Note You need to log in before you can comment on or make changes to this bug.