Bug 222996

Summary: CRASH in MergeUVRow_AVX2
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ggaren, peng.liu6, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ggaren: review+
Patch for landing none

Jer Noble
Reported 2021-03-09 14:48:59 PST
CRASH in MergeUVRow_AVX2
Attachments
Patch (2.75 KB, patch)
2021-03-09 14:55 PST, Jer Noble 		ggaren: review+
DetailsFormatted DiffDiff
Patch for landing (3.52 KB, patch)
2021-03-10 09:20 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2021-03-09 14:49:38 PST
<rdar://75183835>
Radar WebKit Bug Importer
Comment 2 2021-03-09 14:49:57 PST
<rdar://problem/75236308>
Jer Noble
Comment 3 2021-03-09 14:55:46 PST
Created attachment 422764 [details] Patch
Geoffrey Garen
Comment 4 2021-03-09 15:24:21 PST
Comment on attachment 422764 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=422764&action=review r=me > Source/ThirdParty/libwebrtc/ChangeLog:13 > + > + Crash logging shows occasional crashes in MergeUVRow_AVX2; the explanation > + for these crashes seems to be a mismatch between the size of the libvpx > + output frame and the size of the CVPixelBuffer where the converted frame > + data is being stored. Add a pre-flight check that will bail out early in > + this scenario. At first I thought this might not be great behavior; but your comment in Radar convinced me. Might be helpful to add that comment in your ChangeLog or in the code.
Geoffrey Garen
Comment 5 2021-03-09 15:24:40 PST
Side note: I think Youenn was looking at a similar crash.
Jer Noble
Comment 6 2021-03-10 09:20:22 PST
<rdar://75183835>
Jer Noble
Comment 7 2021-03-10 09:20:55 PST
Created attachment 422837 [details] Patch for landing
EWS
Comment 8 2021-03-10 13:56:47 PST
Committed r274237: <https://commits.webkit.org/r274237> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422837 [details].
Note You need to log in before you can comment on or make changes to this bug.