Bug 222995

Summary: Add some logging to help debug flaky quota tests
Product: WebKit Reporter: Sihui Liu <sihui_liu>
Component: New BugsAssignee: Sihui Liu <sihui_liu>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, sihui_liu, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=223086
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Sihui Liu
Reported 2021-03-09 14:48:57 PST
...
Attachments
Patch (29.71 KB, patch)
2021-03-09 14:56 PST, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Patch (29.60 KB, patch)
2021-03-10 09:27 PST, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Patch for landing (29.57 KB, patch)
2021-03-11 19:25 PST, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Sihui Liu
Comment 2 2021-03-09 14:56:58 PST
Created attachment 422765 [details] Patch
Sihui Liu
Comment 3 2021-03-10 09:27:06 PST
Created attachment 422838 [details] Patch
youenn fablet
Comment 4 2021-03-11 11:06:52 PST
Comment on attachment 422838 [details] Patch I guess the idea is to remove that logging after investigation. That seems ok. Otherwise, I would go with something like RELEASE_LOG_WITH_LEVEL_IF, pass session IDs as part of the IF, and use Verbose level. And maybe add some test runner API to turn the logging info on a per test basis.
Sihui Liu
Comment 5 2021-03-11 13:52:52 PST
(In reply to youenn fablet from comment #4) > Comment on attachment 422838 [details] > Patch > > I guess the idea is to remove that logging after investigation. > That seems ok. > Otherwise, I would go with something like RELEASE_LOG_WITH_LEVEL_IF, pass > session IDs as part of the IF, and use Verbose level. > > And maybe add some test runner API to turn the logging info on a per test > basis. Yes, let's remove it when tests are fixed: https://bugs.webkit.org/show_bug.cgi?id=223086.
EWS
Comment 6 2021-03-11 14:04:06 PST
commit-queue failed to commit attachment 422838 [details] to WebKit repository. To retry, please set cq+ flag again.
Sihui Liu
Comment 7 2021-03-11 19:25:23 PST
Created attachment 423006 [details] Patch for landing
EWS
Comment 8 2021-03-11 20:42:32 PST
Committed r274323: <https://commits.webkit.org/r274323> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423006 [details].
Radar WebKit Bug Importer
Comment 9 2021-03-11 20:43:17 PST
<rdar://problem/75346752>
Chris Dumez
Comment 10 2021-03-12 10:47:42 PST
Comment on attachment 423006 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=423006&action=review > Source/WebKit/NetworkProcess/NetworkProcess.cpp:2407 > + return; Fails to call completion handler.
Chris Dumez
Comment 11 2021-03-12 10:50:15 PST
(In reply to Chris Dumez from comment #10) > Comment on attachment 423006 [details] > Patch for landing > > View in context: > https://bugs.webkit.org/attachment.cgi?id=423006&action=review > > > Source/WebKit/NetworkProcess/NetworkProcess.cpp:2407 > > + return; > > Fails to call completion handler. Fixed in <https://commits.webkit.org/r274364> to address assertions on the bots.
Note You need to log in before you can comment on or make changes to this bug.