Bug 222986

Summary: Stop using callOnMainThread() / isMainThread() in WebKit2
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, benjamin, berto, cgarcia, cmarcelo, darin, eric.carlson, ews-watchlist, ggaren, glenn, gustavo, hi, jbedard, jer.noble, joepeck, kkinnunen, philipj, sam, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=223015
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2021-03-09 10:30:21 PST
Stop using callOnMainThread() / isMainThread() is WebKit2 and enforce this rule via the style checker. callOnMainRunLoop() / isMainRunLoop() are safer alternatives in WebKit2 because they do the right thing even if an app uses both WebKit2 and WebKit1 (with WebThread) on iOS.
Attachments
Patch (82.04 KB, patch)
2021-03-09 10:37 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (81.98 KB, patch)
2021-03-09 10:45 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (81.52 KB, patch)
2021-03-09 11:52 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2021-03-09 10:37:26 PST
Created attachment 422724 [details] Patch
Chris Dumez
Comment 2 2021-03-09 10:45:22 PST
Created attachment 422727 [details] Patch
EWS Watchlist
Comment 3 2021-03-09 10:46:18 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Chris Dumez
Comment 4 2021-03-09 11:52:38 PST
Created attachment 422737 [details] Patch
EWS
Comment 5 2021-03-09 14:07:07 PST
Committed r274174: <https://commits.webkit.org/r274174> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422737 [details].
Radar WebKit Bug Importer
Comment 6 2021-03-09 14:08:19 PST
<rdar://problem/75234452>
Chris Dumez
Comment 7 2021-03-09 20:44:20 PST
Follow-up in <https://commits.webkit.org/r274194>.
Note You need to log in before you can comment on or make changes to this bug.