Bug 222986 - Stop using callOnMainThread() / isMainThread() in WebKit2
Summary: Stop using callOnMainThread() / isMainThread() in WebKit2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-09 10:30 PST by Chris Dumez
Modified: 2021-03-09 20:44 PST (History)
20 users (show)

See Also:

Attachments
Patch (82.04 KB, patch)
2021-03-09 10:37 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (81.98 KB, patch)
2021-03-09 10:45 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (81.52 KB, patch)
2021-03-09 11:52 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-03-09 10:30:21 PST 
Stop using callOnMainThread() / isMainThread() is WebKit2 and enforce this rule via the style checker. callOnMainRunLoop() / isMainRunLoop() are safer alternatives in WebKit2 because they do the right thing even if an app uses both WebKit2 and WebKit1 (with WebThread) on iOS.
Comment 1 Chris Dumez 2021-03-09 10:37:26 PST 
Created attachment 422724 [details]
Patch
Comment 2 Chris Dumez 2021-03-09 10:45:22 PST 
Created attachment 422727 [details]
Patch
Comment 3 EWS Watchlist 2021-03-09 10:46:18 PST 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 4 Chris Dumez 2021-03-09 11:52:38 PST 
Created attachment 422737 [details]
Patch
Comment 5 EWS 2021-03-09 14:07:07 PST 
Committed r274174: <https://commits.webkit.org/r274174>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 422737 [details].
Comment 6 Radar WebKit Bug Importer 2021-03-09 14:08:19 PST 
<rdar://problem/75234452>
Comment 7 Chris Dumez 2021-03-09 20:44:20 PST 
Follow-up in <https://commits.webkit.org/r274194>.