Bug 222976

Summary: Cleanup RenderFlexibleBox
Product: WebKit Reporter: Rob Buis <rbuis>
Component: CSSAssignee: Rob Buis <rbuis>
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, svillar, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch none

Rob Buis
Reported 2021-03-09 08:18:35 PST
Cleanup RenderFlexibleBox.
Attachments
Patch (3.46 KB, patch)
2021-03-09 08:20 PST, Rob Buis 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (3.48 KB, patch)
2021-03-09 08:39 PST, Rob Buis 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (3.12 KB, patch)
2021-03-09 12:42 PST, Rob Buis 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (3.14 KB, patch)
2021-03-10 01:25 PST, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (5.35 KB, patch)
2021-03-11 01:03 PST, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (5.50 KB, patch)
2021-03-11 05:04 PST, Rob Buis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2021-03-09 08:20:09 PST
Created attachment 422698 [details] Patch
Rob Buis
Comment 2 2021-03-09 08:39:02 PST
Created attachment 422705 [details] Patch
Rob Buis
Comment 3 2021-03-09 12:42:24 PST
Created attachment 422746 [details] Patch
Rob Buis
Comment 4 2021-03-10 01:25:57 PST
Created attachment 422807 [details] Patch
Rob Buis
Comment 5 2021-03-11 01:03:57 PST
Created attachment 422912 [details] Patch
Sergio Villar Senin
Comment 6 2021-03-11 04:51:21 PST
Comment on attachment 422912 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=422912&action=review Thanks for the cleanup! > Source/WebCore/rendering/RenderFlexibleBox.cpp:1226 > + return std::max(childSize, std::min(transferredSize, contentSize)); This is correct from the current API POV, but I think we should review at some point computeMainSizeFromAspectRatioUsing() because it's OK if it returns a nullopt. Right now it isn't possible because we replace it by 0_lu just before returning but I think that is not very precise. Could you add some FIXME so that we don't forget about it?
Rob Buis
Comment 7 2021-03-11 05:04:31 PST
Created attachment 422924 [details] Patch
EWS
Comment 8 2021-03-11 09:57:26 PST
Committed r274284: <https://commits.webkit.org/r274284> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422924 [details].
Radar WebKit Bug Importer
Comment 9 2021-03-11 09:58:18 PST
<rdar://problem/75320821>
Note You need to log in before you can comment on or make changes to this bug.