Summary: | [GPU Process] ImageBitmap should release its ImageBuffer in the main thread | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Said Abou-Hallawa <sabouhallawa> | ||||||||
Component: | Canvas | Assignee: | Said Abou-Hallawa <sabouhallawa> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | cdumez, changseok, dino, esprehn+autocc, ews-watchlist, gyuyoung.kim, simon.fraser, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 222835 | ||||||||||
Attachments: |
|
Description
Said Abou-Hallawa
2021-03-08 23:53:01 PST
Created attachment 422668 [details]
Patch
Comment on attachment 422668 [details]
Patch
It this covered by tests?
Created attachment 422728 [details]
Patch
(In reply to Simon Fraser (smfr) from comment #2) > Comment on attachment 422668 [details] > Patch > > It this covered by tests? imported/w3c/web-platform-tests/html/canvas/element/imagebitmap/createImageBitmap-in-worker-transfer.html Comment on attachment 422728 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=422728&action=review > Source/WebCore/html/ImageBitmap.cpp:848 > + callOnMainThread([imageBuffer = WTFMove(imageBuffer)]() mutable { }); I doubt the mutable and () are needed. (In reply to Said Abou-Hallawa from comment #4) > (In reply to Simon Fraser (smfr) from comment #2) > > Comment on attachment 422668 [details] > > Patch > > > > It this covered by tests? > > imported/w3c/web-platform-tests/html/canvas/element/imagebitmap/ > createImageBitmap-in-worker-transfer.html Please note in the changeling. Created attachment 422731 [details]
Patch
Committed r274164: <https://commits.webkit.org/r274164> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422731 [details]. *** Bug 222879 has been marked as a duplicate of this bug. *** |