Bug 222938

Summary: TestWebKitAPI WebKit.HitTestResultNodeHandle does not complete with ENABLE_CONTEXT_MENUS=OFF
Product: WebKit Reporter: Stephan Szabo <stephan.szabo>
Component: Tools / TestsAssignee: Stephan Szabo <stephan.szabo>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, don.olmstead, ross.kirsling, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Stephan Szabo
Reported 2021-03-08 13:22:53 PST
WebKit.HitTestResultNodeHandle uses WKBundlePageSetContextMenuClient to set getContextMenuFromDefaultMenu to send the message to complete the test. However, at least testing on WinCairo and PlayStation, when ENABLE_CONTEXT_MENUS is OFF, that will not happen so the test can't complete.
Attachments
Patch (1.92 KB, patch)
2021-03-08 15:13 PST, Stephan Szabo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Stephan Szabo
Comment 1 2021-03-08 15:13:54 PST
Created attachment 422625 [details] Patch
Ross Kirsling
Comment 2 2021-03-08 15:51:46 PST
Comment on attachment 422625 [details] Patch r=me
EWS
Comment 3 2021-03-08 18:45:06 PST
Committed r274128: <https://commits.webkit.org/r274128> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422625 [details].
Radar WebKit Bug Importer
Comment 4 2021-03-08 18:46:20 PST
<rdar://problem/75198343>
Note You need to log in before you can comment on or make changes to this bug.