Summary: | Simplify CallbackAggregator in WebsiteDataStore::fetchDataAndApply() | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||
Component: | WebKit2 | Assignee: | Chris Dumez <cdumez> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | achristensen, beidson, darin, ggaren, kkinnunen, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=222837 | ||||||||||
Attachments: |
|
Description
Chris Dumez
2021-03-08 13:08:30 PST
Created attachment 422609 [details]
Patch
Comment on attachment 422609 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=422609&action=review > Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:432 > +private: Should indent this 4? > Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:441 > + auto callbackAggregator = adoptRef(new CallbackAggregator(fetchOptions, WTFMove(queue), WTFMove(apply), *this)); Seems like there is a missing * here so we get a Ref<> instead of a RefPtr<>. (In reply to Darin Adler from comment #2) > Comment on attachment 422609 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=422609&action=review > > > Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:432 > > +private: > > Should indent this 4? > > > Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:441 > > + auto callbackAggregator = adoptRef(new CallbackAggregator(fetchOptions, WTFMove(queue), WTFMove(apply), *this)); > > Seems like there is a missing * here so we get a Ref<> instead of a RefPtr<>. Oh right. We used to not do that to make capture by value convenient in the lambdas. However, Ref<> has a copy-constructor nowadays! Created attachment 422646 [details]
Patch
Created attachment 422649 [details]
Patch
Committed r274130: <https://commits.webkit.org/r274130> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422649 [details]. |